Skip to content

dependabot: Reverting unapproved changes i did#272

Merged
aliceinwire merged 1 commit intokernelci:mainfrom
nuclearcat:fixing-mistake
Apr 30, 2026
Merged

dependabot: Reverting unapproved changes i did#272
aliceinwire merged 1 commit intokernelci:mainfrom
nuclearcat:fixing-mistake

Conversation

@nuclearcat
Copy link
Copy Markdown
Member

At night i was reviewing state of code in projects, and while enabling on kernelci-{core,api,pipeline,storage} i enabled here also by mistake without prior discussion and PR.
Reverting changes.

At night i was reviewing state of code in projects, and while enabling on
kernelci-{core,api,pipeline,storage} i enabled here also by mistake
without prior discussion and PR.
Reverting changes.

Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
@aliceinwire
Copy link
Copy Markdown
Member

aliceinwire commented Apr 30, 2026

Thanks for the contribution! Moving forward, could you please submit a PR for review next time rather than committing directly to the production branch? While I know you’ve followed that pattern in other KernelCI repos (core, api, etc.), I would prefer if we're trying to move away from that behavior to ensure we have a solid audit trail for every change. It helps us keep a clean record and prevents any accidental regressions.
Beyond just the record-keeping, I’m concerned about the technical risks of force-pushing to master. It carries a high risk of overwriting someone else's work and forces everyone else on the team to manually fix their local histories. Using PRs ensures our CI tools can catch issues before they hit production, keeping the main branch stable for everyone.

Ref commit: 9349ab8

@aliceinwire aliceinwire reopened this Apr 30, 2026
@aliceinwire aliceinwire merged commit 67cd4ad into kernelci:main Apr 30, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants