fix(bisect.py): Fix initial tree creation and params rename #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If linux tree source code doesn't exist (workdir), bisection will fail due wrong sequence of commands. Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
nuclearcat
force-pushed
the
fix-bisect
branch
from
e9cf99a to
6e41708
Compare
Make git bisection failure more verbose, to understand what is happening on error. Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
Contributor
|
Looks good. Thank you! |
Member
|
nice, looks good! |
Member
|
this is draft, is it ok to be a draft? |
platformfilter and jobfilter a bit difficult to read, so let's change parameters to job-filter and platform-filter. Updating documentation accordingly. Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
nuclearcat
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1)If linux tree source code doesn't exist (workdir), bisection will fail due wrong sequence of commands.
2)Change parameter names from platformfilter and jobfilter to job-filter and platform-filter