use kci_err() for error messages across codebase #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This is a rebase on top of #81 to solve conflicts ahead of time without having to asking Denys to redo things. |
Member
|
@padovan please rebase |
padovan
force-pushed
the
use_kci_err
branch
2 times, most recently
from
6aca51a to
d6bb2e0
Compare
aliceinwire
reviewed
Jan 17, 2025
| @@ -0,0 +1,19 @@ | |||
| #!/usr/bin/env python3 | |||
Member
There was a problem hiding this comment.
This is too big of PR for review it correctly but this file looks not unused
Thi commit changes all secho error messages with fg="red" as parameter to kci_err(). Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thi commit changes all secho error messages with fg="red" as parameter to kci_err().