rootfs: debos: fix dangling /init symlink#3104
Merged
Merged
Conversation
/init pointed at /usr/bin/systemd, which has never existed on Debian (systemd is at /usr/lib/systemd/systemd; /sbin/init is the working symlink). LAVA's apply-overlay-ramdisk repacks the cpio so the bug is invisible there, but booting the published rootfs.cpio.gz as a raw initramfs (tuxrun, plain qemu -initrd) panics in mount_root_generic. Point /init at the real systemd binary. Signed-off-by: Ben Copeland <ben.copeland@linaro.org>
Member
Author
|
Tested locally with tuxrun, but not tested through LAVA, but since the previous symlink target was non-existent, LAVA's existing flow can't have been depending on it |
Member
|
Amazing find! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/init pointed at /usr/bin/systemd, which has never existed on Debian (systemd is at /usr/lib/systemd/systemd; /sbin/init is the working symlink). LAVA's apply-overlay-ramdisk repacks the cpio so the bug is invisible there, but booting the published rootfs.cpio.gz as a raw initramfs (tuxrun, plain qemu -initrd) panics in mount_root_generic. Point /init at the real systemd binary.