test_lava.py: Modify example in function comment of get_device_type_by_name.#545
Closed
wangmingyu84 wants to merge 1 commit into
Closed
test_lava.py: Modify example in function comment of get_device_type_by_name.#545wangmingyu84 wants to merge 1 commit into
wangmingyu84 wants to merge 1 commit into
Conversation
…y_name. The example of the function does not match the code. Signed-off-by: Wang Mingyu <wangmy@cn.fujitsu.com>
gctucker
added
staging-skip
gctucker
added a commit
to kernelci/kernelci-deploy
that referenced
this pull request
Jan 5, 2021
Apparently it's possible to create a PR from an "unknown" repository, such as this one: kernelci/kernelci-core#545 Since the user name is currently derived from the source repository, it can't be verified whether this is from a trusted user. Skip the PRs with an unknown repository for now. Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
Collaborator
|
Sorry this got closed by accident when the |
Collaborator
|
@wangmingyu84 I've now simplified the code: #590. That function was from a legacy implementation before the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example of the function does not match the code.
Signed-off-by: Wang Mingyu wangmy@cn.fujitsu.com