Fix(http): Normalize header case for caching#6
Merged
nuclearcat merged 1 commit intokernelci:mainfrom Aug 8, 2025
Merged
Conversation
Headers from upstream servers can have inconsistent casing (e.g., "ETag" vs "etag"). This was causing issues with cache lookups, as the comparison was case-sensitive. This commit fixes the issue by: - Converting all header keys to lowercase before storing them in the cache metadata file. - Using lowercase keys when retrieving headers for cache validation (ETag, Last-Modified). This ensures that cache lookups are case-insensitive and therefore more robust.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Headers from upstream servers can have inconsistent casing (e.g., "ETag" vs "etag"). This was causing issues with cache lookups, as the comparison was case-sensitive.
This commit fixes the issue by:
This ensures that cache lookups are case-insensitive and therefore more robust.