target: accept any CONFIG_*=<value> inline fragment#277
Merged
roxell merged 1 commit intoApr 22, 2026
Conversation
The old regex only matched =y/=m/=n and "is not set" lines. That misses
a lot of real config: =1 and =0 are common for bools (kselftest's
tools/testing/selftests/bpf/config uses =1 for
CONFIG_BOOTPARAM_SOFTLOCKUP_PANIC), and fragments can also include hex,
string, and int symbols.
tuxmake was rejecting those as "Unsupported kconfig fragment" even
though they work fine once they hit olddefconfig.
Let kconfig handle validation. merge_config.sh and olddefconfig already
know each symbol's type and print a reasonable error when the value is
wrong, so there's no point replicating that here. Keep the two shapes
("CONFIG_X=..." and "# CONFIG_X is not set") so pure junk still gets
caught.
Signed-off-by: Ben Copeland <ben.copeland@linaro.org>
bhcopeland
force-pushed
the
kconfig-permissive-inline-fragment
branch
from
b838fe4 to
6ea7dfb
Compare
roxell
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old regex only matched =y/=m/=n and "is not set" lines. That misses a lot of real config: =1 and =0 are common for bools (kselftest's tools/testing/selftests/bpf/config uses =1 for
CONFIG_BOOTPARAM_SOFTLOCKUP_PANIC), and fragments can also include hex, string, and int symbols.
tuxmake was rejecting those as "Unsupported kconfig fragment" even though they work fine once they hit olddefconfig.
Let kconfig handle validation. merge_config.sh and olddefconfig already know each symbol's type and print a reasonable error when the value is wrong, so there's no point replicating that here. Keep the two shapes ("CONFIG_X=..." and "# CONFIG_X is not set") so pure junk still gets caught.