Container Volume test failes on Styx spin with latest Infix

[rical]

Current Behavior

Container volume test fails in CI on Spins with existing container.

Starting test 0047-container_volume
Test File: /home/github-optricans/actions-runner/_work/infix-canary/infix-canary/test/case/../../infix/test/case/infix_containers/container_volume/test.py
Test Cmdl: []
2025-11-11 04:53:32 # Starting (2025-11-11 04:53:32)
2025-11-11 04:53:32 # host:    host
2025-11-11 04:53:32 #     mgmt:    d4a
2025-11-11 04:53:32 #     data:    d4b
2025-11-11 04:53:32 # target:  dut4
2025-11-11 04:53:32 #     mgmt:    e1
2025-11-11 04:53:32 #     data:    e2
2025-11-11 04:53:32 #
2025-11-11 04:53:32 # Waiting for DUTs to become reachable...
2025-11-11 04:53:32 # Probing dut4 on port d4a for IPv6LL mgmt address ...
2025-11-11 04:53:32 # Testing using NETCONF
2025-11-11 04:53:32 # Connecting to mgmt IP fe80::2a0:85ff:fe00:401%d4a:830 ...
2025-11-11 04:53:32 # YANG models downloaded.
2025-11-11 04:53:37 # Waiting for DUTs to become reachable...
2025-11-11 04:53:37 # Probing dut4 on port d4a for IPv6LL mgmt address ...
2025-11-11 04:53:37 ok 1 - Set up topology and attach to target DUT
2025-11-11 04:53:39 ok 2 - Create container with volume from bundled OCI image
2025-11-11 04:53:46 ok 3 - Verify container has started
2025-11-11 04:53:47 ok 4 - Modify container volume content
2025-11-11 04:53:47 ok 5 - Verify container volume content
2025-11-11 04:53:52 not ok 6 - Upgrade container
2025-11-11 04:53:52 # Exiting (2025-11-11 04:53:52)
2025-11-11 04:53:52 # Traceback (most recent call last):
2025-11-11 04:53:52 #   File "/home/github-optricans/actions-runner/_work/infix-canary/infix-canary/test/case/../../infix/test/case/infix_containers/container_volume/test.py", line 64, in <module>
2025-11-11 04:53:52 #     test.fail(msg)
2025-11-11 04:53:52 # TypeError: Test.fail() takes 1 positional argument but 2 were given
2025-11-11 04:53:52 #
test error, no plan

Doesn't really seem intermittent. Used to work in v25.08.1 but fails when upgrading Infix to v25.10.0.

Expected Behavior

From CI on the same Spin with Infix v25.08.1

Starting test 0047-container_volume
Test File: /home/github-optricans/actions-runner/_work/infix-canary/infix-canary/test/case/../../infix/test/case/infix_containers/container_volume/test.py
Test Cmdl: []
2025-11-11 04:06:28 # Starting (2025-11-11 04:06:28)
2025-11-11 04:06:28 # host:    host
2025-11-11 04:06:28 #     mgmt:    d1a
2025-11-11 04:06:28 #     data:    d1b
2025-11-11 04:06:28 # target:  dut1
2025-11-11 04:06:28 #     mgmt:    e1
2025-11-11 04:06:28 #     data:    e2
2025-11-11 04:06:28 #
2025-11-11 04:06:28 # Waiting for DUTs to become reachable...
2025-11-11 04:06:28 # Probing dut1 on port d1a for IPv6LL mgmt address ...
2025-11-11 04:06:28 # Testing using NETCONF
2025-11-11 04:06:28 # Connecting to mgmt IP fe80::2a0:85ff:fe00:101%d1a:830 ...
2025-11-11 04:06:28 # YANG models downloaded.
2025-11-11 04:06:32 # Waiting for DUTs to become reachable...
2025-11-11 04:06:32 # Probing dut1 on port d1a for IPv6LL mgmt address ...
2025-11-11 04:06:32 ok 1 - Set up topology and attach to target DUT
2025-11-11 04:06:32 ok 2 - Create container with volume from bundled OCI image
2025-11-11 04:06:41 ok 3 - Verify container has started
2025-11-11 04:06:42 ok 4 - Modify container volume content
2025-11-11 04:06:42 ok 5 - Verify container volume content
2025-11-11 04:06:47 ok 6 - Upgrade container
2025-11-11 04:06:51 ok 7 - Verify container volume content survived upgrade
2025-11-11 04:06:51 # Exiting (2025-11-11 04:06:51)
2025-11-11 04:06:51 7..7

Steps To Reproduce

Check Infix Canary CI.

Additional information

No response

[troglobit]

This looks suspiciously a lot like commit a943007 is somehow missing. That commit adds an optional error message to infamy/tap.py:fail() and the test output above fails on test/case/infix_containers/container_volume/test.py:64 which calls fail(msg).