Fix NETCONF backend in Infamy to propagate RPC errors #1257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The put_config() retry loop was catching and printing RpcError exceptions but never re-raising them after exhausting retries. This caused tests to silently continue despite configuration failures, masking validation errors. Now properly propagates errors after all retries are exhausted, matching the error handling behavior of the RESTCONF backend. Fixes #1250 Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
mattiaswal
approved these changes
Nov 15, 2025
mattiaswal
approved these changes
Nov 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
put_config()retry loop was catching and printingRpcErrorexceptions but never re-raising them after exhausting retries. This caused tests to silently continue despite configuration failures, masking validation errors.The fix propagates errors after all retries are exhausted, matching the error handling behavior of the RESTCONF backend.
Checklist
Tick relevant boxes, this PR is-a or has-a: