Skip to content

Conversation

@mattiaswal
Copy link
Contributor

@mattiaswal mattiaswal commented Dec 16, 2025

Description

Bump sysrepo,lignetconf2, libyang and netopeer2

This update got pretty messy, since libyang had some
breaking changes. And unfortunatly rousette, libyang-cpp
and sysrepo-cpp has not made any new release yet.

Checklist

Tick relevant boxes, this PR is-a or has-a:

  • Bugfix
    • Regression tests
    • ChangeLog updates (for next release)
  • Feature
    • YANG model change => revision updated?
    • Regression tests added?
    • ChangeLog updates (for next release)
    • Documentation added?
  • Test changes
    • Checked in changed Readme.adoc (make test-spec)
    • Added new test to group Readme.adoc and yaml file
  • Code style update (formatting, renaming)
  • Refactoring (please detail in commit messages)
  • Build related changes
  • Documentation content changes
    • ChangeLog updated (for major changes)
  • Other (please describe):

Previously rousette did not install the yang models so we kept a copy
of them in confd. Now it is implemented in rousette, let them install
their models.
Incompatible changes in YANG models for netconf.
@mattiaswal mattiaswal added the ci:main Build default defconfig, not minimal label Dec 16, 2025
@mattiaswal mattiaswal force-pushed the upgrade-sysrepo branch 2 times, most recently from ac8ec21 to b3c3dde Compare December 16, 2025 17:12
We previously run a draft version of a lot of YANG models,
netconf-server,ssh-server and mode. Now they are released
with minor changes.

infix-meta is an exception, here we had to remove the obsolete
marker of the node and value, since this is no longer allowed in
libyang.
This update got pretty messy, since libyang had some
breaking changes. And unfortunatly rousette, libyang-cpp
and sysrepo-cpp has not made any new release yet.
@mattiaswal mattiaswal marked this pull request as ready for review December 16, 2025 18:30
@mattiaswal mattiaswal requested review from troglobit and wkz December 16, 2025 18:30
Copy link
Contributor

@wkz wkz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 👏 👏

My only concern is the exposure of meta/version, but maybe we'll just have to live with that one. Can we reject updates to it in the edit-config RPC?

@wkz
Copy link
Contributor

wkz commented Dec 16, 2025

Failing test on alder@monza (support_collect) is likely due to the SSH test bug fixed in 0298dc3

@mattiaswal
Copy link
Contributor Author

Great work! 👏 👏

My only concern is the exposure of meta/version, but maybe we'll just have to live with that one. Can we reject updates to it in the edit-config RPC?

Thats my problem as well. But i think we can live with it for now.

@wkz wkz merged commit 45ff5d2 into main Dec 17, 2025
6 of 7 checks passed
@wkz wkz deleted the upgrade-sysrepo branch December 17, 2025 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:main Build default defconfig, not minimal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants