Container restart on env #1386
Merged
Container restart on env #1386
+50
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Type a command, regret you typed so much before checking something else, comment it out for later with Meta-# (Alt-Shift-3). The whole line is now commented out and saved to history. Recall it later with Ctrl-P or Up arrow, delete the leading # with Ctrl-D, and run it. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Environment variables are stored in a separate .env file from the main container script. The config SHA256 checksum only covered the script file, so changes to env vars went undetected -- the container was not recreated and kept running with stale values. Include the env file contents in the config checksum calculation so that any change to environment variables triggers a proper container restart. Fixes #1313 Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
troglobit
force-pushed
the
container-restart-on-env
branch
from
379d1e5 to
eeabb44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Include container env file in sha calculation of config to trigger container restart on env changes. Fixes #1313
Checklist
Tick relevant boxes, this PR is-a or has-a: