feat(reusable-visual-tests, update-snapshots): resolve runner via resolve-runner.yml#43
Merged
Merged
Conversation
…olve-runner.yml Both visual-tests workflows hardcoded runs-on: ubuntu-latest, blocking callers from moving these jobs to self-hosted runners. Route them through resolve-runner.yml@v2.0.0 so they honor caller-repo vars.RUNNER_HEAVY (same mechanism CI build/lint/test already uses).
There was a problem hiding this comment.
Pull request overview
Updates the visual testing reusable workflows to resolve runner labels through the existing resolve-runner.yml mechanism so caller repos/orgs can centrally control whether jobs run on GitHub-hosted or self-hosted runners via vars.RUNNER_HEAVY / vars.RUNNER_LIGHT.
Changes:
- Added a
resolve-runnerreusable-workflow job toreusable-visual-tests.ymland wiredvisual-teststo use the resolved heavy runner label. - Added a
resolve-runnerreusable-workflow job toupdate-snapshots.ymland wired the dispatcher job to use the resolved light runner label. - Added a Changesets entry documenting the runner-resolution behavior change for consumers.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/update-snapshots.yml | Adds resolve-runner and switches the dispatcher to runs-on: ${{ needs.resolve-runner.outputs.light }}. |
| .github/workflows/reusable-visual-tests.yml | Adds resolve-runner and switches the Playwright suite job to runs-on: ${{ needs.resolve-runner.outputs.heavy }}. |
| .changeset/visual-tests-resolve-runner.md | Documents the new runner-resolution behavior and consumer implications. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Both jobs now use resolve-runner heavy output. Bumped changeset to major since standalone consumers without vars.RUNNER_HEAVY will now resolve to self-hosted instead of ubuntu-latest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
runs-on: ubuntu-latest, blocking callers from moving these jobs to self-hosted runners.reusable-visual-tests.ymlandupdate-snapshots.ymlthroughresolve-runner.yml@v2.0.0so they honor caller-repovars.RUNNER_HEAVY— same mechanismci-build-lint-test.yml/ci-quality.ymlalready use.RUNNER_HEAVYon a caller (e.g.house-of-slabs) moves CI + visual jobs to self-hosted in lockstep.Behavior note
Org-level callers (kethalia / chillwhales / phlox-labs) set
vars.RUNNER_HEAVY=ubuntu-latestorg-wide, so they're unaffected.Standalone callers without that var will resolve to
self-hosted(the resolve-runner default) and must pinRUNNER_HEAVY=ubuntu-latestto preserve prior behavior. Called out in the changeset.Test plan
kethalia/workflowshouse-of-slabsVisual Tests run resolves runner viaresolve-runnerstep (visible in run logs)vars.RUNNER_HEAVYunset, jobs continue to run onubuntu-latest(kethalia org default)