Skip to content

Refactor Engines to rely on ClauseFactory/Clause#11

Merged
kettasoft merged 2 commits intomasterfrom
refactor/engines-clause-refactor
Aug 19, 2025
Merged

Refactor Engines to rely on ClauseFactory/Clause#11
kettasoft merged 2 commits intomasterfrom
refactor/engines-clause-refactor

Conversation

@kettasoft
Copy link
Copy Markdown
Owner

Overview

This pull request refactors the Engines to depend more on ClauseFactory and Clause,
resulting in cleaner and more consistent filtering logic across the package.

Changes

  • Updated Engines to delegate field/operator resolution to ClauseFactory.
  • Improved validation and consistency of clause handling.
  • Reduced duplicated logic between different Engines.
    for safer relation path validation.

Benefits

  • Centralized clause creation logic.
  • Easier to maintain and extend Engines in the future.
  • Clearer separation of responsibilities between Engines and ClauseFactory.

Abdalrhman Emad Saad added 2 commits August 19, 2025 17:05
- Updated Engines to rely more on ClauseFactory and Clause for building conditions
- Removed duplicated logic for operator/field validation
- Improved consistency and readability across engines
@kettasoft kettasoft merged commit 285d65d into master Aug 19, 2025
1 check passed
@kettasoft kettasoft deleted the refactor/engines-clause-refactor branch August 27, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant