Conversation
added 2 commits
August 28, 2025 19:27
- Centralized sanitizing so it runs consistently for all filter engines. - Fixed missing sanitizing in engines that previously bypassed it. - Guarantees consistent behavior and prevents unsafe/invalid inputs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where some filter engines did not apply sanitizing,
leading to inconsistent behavior and potential unsafe inputs.
Changes
Why
Sanitizing is a core part of Filterable. Missing it in some engines is a bug
that could cause unexpected behavior or vulnerabilities. This PR ensures a
consistent and safe experience across all engines.
Tests