Update Eloquent Builder references to use Contracts for improved type consistency #38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces all usages of:
with:
across the entire package.
The change ensures that the package can accept any Eloquent builder–compatible instance, not only the base
Illuminate\Database\Eloquent\Builder.Motivation
The previous implementation strictly type-hinted
Illuminate\Database\Eloquent\Builder, which caused type conflicts when passing relationship builders such asHasMany,HasOne, orBelongsTointoFilterable::setBuilder().Example of the issue:
This throws an error because:
posts()returns an instance ofIlluminate\Database\Eloquent\Relations\HasManyHasManyimplements the contractIlluminate\Contracts\Database\Eloquent\BuilderIlluminate\Database\Eloquent\BuilderWhy the Contract is More Appropriate
Laravel relationship builders implement the contract, not the concrete
Builderclass.By switching to the contract:
setBuilder()can accept query builders returned from relationships.$hasMany->getQuery()or similar workarounds.This makes the package behave consistently with Laravel's own expectations regarding builder polymorphism.
Result
After this change:
works as expected without throwing binding or instantiation errors.
Additional Notes