Adding Harmonica to Stage 5

[kevin218]

As another means to fit asymmetric limbs, this PR integrates David Grant's Harmonica package into Eureka!. Initial tests indicate that Harmonica is significantly faster than Catwoman and has more flexibility in terms of the planet shape. Harmonica also works well as a replacement for Batman.

This push has fully functioning code using the latest version of Eureka!. I've verified that is produces nearly identical results to Catwoman. This PR also includes documentation and new pytest routines.

[taylorbell57]

Any updates on this @kevin218?

[kevin218]

Sadly, this project keeps getting bumped down my ToDo list due to more pressing tasks, like Cycle 4 budgets. Hopefully soon...

[codecov]

Codecov Report

Attention: Patch coverage is 39.41176% with 103 lines in your changes missing coverage. Please review.

Project coverage is 52.21%. Comparing base (d24cd6f) to head (e9ab0b2).

Files with missing lines	Patch %	Lines
src/eureka/S6_planet_spectra/s6_spectra.py	16.41%	56 Missing ⚠️
src/eureka/S5_lightcurve_fitting/plots_s5.py	8.57%	32 Missing ⚠️
...eka/S5_lightcurve_fitting/models/HarmonicaModel.py	77.77%	10 Missing ⚠️
src/eureka/S5_lightcurve_fitting/fitters.py	37.50%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #750      +/-   ##
==========================================
- Coverage   52.35%   52.21%   -0.14%     
==========================================
  Files         117      118       +1     
  Lines       15063    15218     +155     
==========================================
+ Hits         7886     7946      +60     
- Misses       7177     7272      +95     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[taylorbell57]

Just a coupe of small edits left.

Maybe let's get this PR and my Stage 1 PR both merged before releasing v1.2.1?

[taylorbell57]

Hmm, I just realized that something in this PR made it so that the NIRCam tests never complete - all the automated tests were killed after running continuously for 6 hours, and my own local test never completed either...

[taylorbell57]

Aha, I figured it out - there will be a patch in my in-prep jaxoplanet PR #766

[kevin218]

Thanks for tracking down the error.

…

On Fri, May 16, 2025, 9:48 PM Taylor James Bell ***@***.***> wrote: *taylorbell57* left a comment (kevin218/Eureka#750) <#750 (comment)> Aha, I figured it out - there will be a patch in my in-prep jaxoplanet PR #766 <#766> — Reply to this email directly, view it on GitHub <#750 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFC2C7J5CMI2ITJE5HETZVD262IOPAVCNFSM6AAAAABYPNPRIGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQOBXHE2DSOBZGU> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>