Skip to content

Improve formBuilder event dispatch and improve capturing of all stage modifications #1611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kevinchappell merged 6 commits into from
May 13, 2025
Merged

Improve formBuilder event dispatch and improve capturing of all stage modifications #1611

kevinchappell merged 6 commits into from
May 13, 2025

Conversation

@lucasnetau
Copy link
Collaborator

@lucasnetau lucasnetau commented May 5, 2025 •
edited
Loading

This PR does two things:

  • Call helper.save() after fields are reordered via the manual sorting buttons Fixes Sort buttons don't trigger formSaved event #1596
  • Refactor events:
    • Remove events.js legacy IE11 support
    • Create events with Bubbling enabled
    • Dispatch events at the stage level (or where appropriate) instead of at document level
  • Added save calls when field options were re-ordered or added
  • Change to using the input event instead of 'click blur change keyup' to detect changed to attributes in modern browsera
  • Ensure that label changes are saved

@lucasnetau lucasnetau requested a review from kevinchappell May 5, 2025 04:44
@lucasnetau lucasnetau mentioned this pull request May 5, 2025
Closed
@lucasnetau lucasnetau changed the title Fix/1596 Call save after changing field order in stage via sorting buttons Improve formBuilder event dispatch and improve capturing of all stage modifications May 12, 2025
kevinchappell
kevinchappell approved these changes May 13, 2025
View reviewed changes
Copy link
Owner

@kevinchappell kevinchappell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was long overdue. great work

@kevinchappell kevinchappell merged commit 060c600 into kevinchappell:master May 13, 2025
1 check passed
@github-actions
Copy link

github-actions bot commented May 13, 2025

🎉 This PR is included in version 3.19.15 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lucasnetau lucasnetau deleted the fix/1596 branch May 13, 2025 01:02
@lucasnetau
Copy link
Collaborator Author

lucasnetau commented May 13, 2025

this was long overdue. great work

Yes, now there hopefully is no need to use a ChangeObserver to monitor for stage changes in applications, testing with my big application now.

@lucasnetau lucasnetau mentioned this pull request May 13, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevinchappell kevinchappell kevinchappell approved these changes

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Sort buttons don't trigger formSaved event

2 participants

@lucasnetau @kevinchappell