Add tag catalog and sidebar tag filtering#1
Merged
Conversation
github-actions
Bot
added
size:XXL
vouch:trusted
- Project tag catalog into snapshots and projections - Add tag invariants, persistence, and schema plumbing - Update tests and read models for tag-aware data
- Swap inline tag chips for a compact filter dropdown - Add project tag assignment and tag management actions - Cover new tag toggling logic with tests
- Replace the tag filter dropdown with inline selectable pills - Add pill context menus for rename and delete actions - Keep clear/new tag actions in the sidebar header
- Reuse a shared header component for sidebar sections - Simplify tag filter pills and align tag/project controls
- Increase tag pill text size for better readability - Add foreground tint to the default unpressed state
- Move TagFilterPills (renamed SidebarTagFilter), the project-tag editor menu (renamed ProjectTagsEditor), and the shared SidebarSectionHeader out of Sidebar.tsx into apps/web/src/components/sidebar/ - Drop now-unused imports from Sidebar.tsx (XIcon, Toggle, Collapsible*, MenuItem, MenuCheckboxItem, cn) - Sidebar.tsx shrinks by ~330 lines; the new components are short, single-purpose, and easy to review on their own No behavior change. Dialog state, store selectors, and command-dispatch handlers stay in Sidebar.tsx; props on the call sites are unchanged.
Co-locate the sidebar-specific components with their siblings (PlanSidebar, AppSidebarLayout, etc.) so the components/ folder follows the same flat layout used by the rest of the app. - git mv four files out of components/sidebar/ into components/ - Re-anchor relative imports (../../foo -> ../foo, ../ui/x -> ./ui/x) - Update Sidebar.tsx imports to drop the ./sidebar/ path prefix - Remove the now-empty sidebar/ subdirectory
kevinher7
force-pushed
the
feature/kevin/create_tag_filtering
branch
from
53d51cf to
ae00cb4
Compare
- Rewrap menu and collapsible imports - Tighten component and popup formatting - No behavior change
kevinher7
changed the title
- Preserve project shape while overriding the sortable id - Keep project tag filtering and thread sorting logic unchanged
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
projection_tagstable andtags_jsoncolumn onprojection_projectsintroduced by Banded migration ids + set-difference runner #2 (already onpersonal).Changes
Server / orchestration
commandInvariants,decider,projector, and the projection pipeline.ProjectionTagspersistence layer + service with normalized-name uniqueness.ProjectionProjectsupdated to read/write thetags_jsoncolumn.ws.tsfor tag mutations and snapshot delivery.Web / UI
SidebarTagFilterandSidebarSectionHeadercomponents;ProjectTagsEditorfor assigning tags to projects.Sidebar.tsxextended with collapsible tag pills and dropdown selection.store/uiStateStoretrack tag-filter state.components/sidebar/intocomponents/.Contracts
packages/contracts/src/orchestration.tsand a sharedTagIdbase schema.Testing
5001_ProjectionTagstests live onpersonalvia Banded migration ids + set-difference runner #2.bun fmt,bun lint, andbun typecheckbefore merging.Notes
personalafter Banded migration ids + set-difference runner #2 merged. The migration runner refactor, banded-id convention, and5001_ProjectionTagsmigration are no longer in this PR — they ship onpersonalindependently.personal, not in this PR): PR-template-aware generation, username-prefixed branch names, editor command pre-resolution.