Skip to content

Fix COM hooks#131

Merged
kevoreilly merged 5 commits into
kevoreilly:capemonfrom
KillerInstinct:fix_com_hooks
May 8, 2026
Merged

Fix COM hooks#131
kevoreilly merged 5 commits into
kevoreilly:capemonfrom
KillerInstinct:fix_com_hooks

Conversation

@KillerInstinct
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request expands the monitored WMI namespaces to include subscription and TaskScheduler paths and refactors set_com_hooks to iterate through all potential hooks instead of returning early. A logic flaw was identified in the hook failure handling: initializing the return status to -1 causes actual failures to be silently ignored because the condition ret != -1 evaluates to false. A suggestion was provided to use a distinct initialization value to ensure failed hooks are correctly detected and logged.

Comment thread hooks.c Outdated
@kevoreilly kevoreilly merged commit 230122a into kevoreilly:capemon May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants