Fix COM hooks#131
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request expands the monitored WMI namespaces to include subscription and TaskScheduler paths and refactors set_com_hooks to iterate through all potential hooks instead of returning early. A logic flaw was identified in the hook failure handling: initializing the return status to -1 causes actual failures to be silently ignored because the condition ret != -1 evaluates to false. A suggestion was provided to use a distinct initialization value to ensure failed hooks are correctly detected and logged.
Remove debug output for initialized com hooks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.