Skip to content

Update most dependencies#60

Merged
sindresorhus merged 4 commits intokevva:masterfrom
realityking:dependencies
Jul 11, 2018
Merged

Update most dependencies#60
sindresorhus merged 4 commits intokevva:masterfrom
realityking:dependencies

Conversation

@realityking
Copy link
Copy Markdown
Contributor

@realityking realityking commented Apr 7, 2018

The exception being download, I'll open a separate PR for it once this one is merged. The unit tests are fighting me.

As an aside, now that the dependencies are all Promise-based, what do you think about changing the API of bin-wrapper to be Promise-based?

@coreyfarrell
Copy link
Copy Markdown

I think the update of download will require merge of kevva/download#163.

@DesWurstes
Copy link
Copy Markdown

Updating kevva/download solves tunnel-agent < 0.6.0 vulnerability, from bin-wrapper > download > caw > tunnel-agent

@XhmikosR
Copy link
Copy Markdown
Contributor

Ping @kevva

@rejas
Copy link
Copy Markdown
Contributor

rejas commented Jul 5, 2018

If you need help @kevva testing and progressing these PRs and issues feel free to contact me, would be glad to help out (also with kevva/download#163)

@realityking
Copy link
Copy Markdown
Contributor Author

@sindresorhus Could you have a look at this one?

@sindresorhus
Copy link
Copy Markdown
Contributor

what do you think about changing the API of bin-wrapper to be Promise-based?

👍

@sindresorhus sindresorhus merged commit fc3bb3e into kevva:master Jul 11, 2018
@sindresorhus
Copy link
Copy Markdown
Contributor

@rejas I'm sure @kevva could use some help. Triage and/or fix issues: https://github.com/kevva/bin-wrapper/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc for example.

@realityking
Copy link
Copy Markdown
Contributor Author

Thanks @sindresorhus! I'll follow-up with PRs for a Promise based API and the download dependency later this week :)

@sindresorhus
Copy link
Copy Markdown
Contributor

I think the update of download will require merge of kevva/download#163.

New download version is published.

@sindresorhus
Copy link
Copy Markdown
Contributor

@realityking Sounds good! 👌

@realityking realityking deleted the dependencies branch July 11, 2018 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants