ci: dogfood the matrix and bench subcommands in pty-e2e#5
Merged
Conversation
The pty-e2e jobs ran `pitty run` over the positive and meta tiers but never exercised the matrix/bench subcommands, so a regression in `pitty matrix` or `pitty bench` would slip past CI even though sample scenarios for them exist. Add a samples tier that runs both subcommands over e2e/scenarios/samples on ubuntu and macOS; each exits non-zero on a failing cell/run. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pty-e2ejobs (ubuntu + macOS) dogfoodedpitty runover the positive and meta tiers, but never exercised thematrix/benchsubcommands — so a regression inpitty matrixorpitty benchwould not be caught by CI despite sample scenarios existing for them.pitty matrix(single- and multi-axis) andpitty benchovere2e/scenarios/samples/. Each subcommand exits 0 on an all-pass scenario and non-zero on a failing cell/run, so it acts as a real gate.Test plan
pty-e2egates greenpitty matrix(matrix-shell, matrix-multi-axis) andpitty bench(bench-shell --runs 3) all exit 0