Conversation
This was referenced Apr 24, 2026
6 tasks
Member
Author
|
I cannot reproduce the test failures that CI sees "locally" for some reason. |
Member
Author
|
Using a debug build this test seems to uncover a true issue that has laid dormant up until now. Specifically, this assert fires: Line 62 in 2d52147 That in turn is becaus DDML/src/CaloCloudsTwoAngleModel.cc Lines 46 to 49 in 2d52147 Not sure which of these need to be fixed. |
Avoids some refernce counting issues **but needs a proper fix**
Make them correspond to what we actually pass on to inference as this is asserted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
ENDRELEASENOTES
The ref-counting issue was introduced with #10 (but since we didn't have any tests it wasn't notice then).