This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Add keybaseca sign command to sign keys manually when keybase is down#15
Merged
Add keybaseca sign command to sign keys manually when keybase is down#15
Conversation
Also: - Adds tests for `keybaseca sign` that verify that it generates a correct signed key - Updates docs to explain `keybaseca sign` (and keep the docs on doing it manually via ssh-keygen in case anything ever breaks with `keybaseca sign`) - Refactored key signing to live in a single function that is called by `keybaseca sign` and the signature request handler. - Updates the version of urfave/cli in order to pull in a recent change that added support for making CLI flags required. - Adds `strings.TrimSpace(...)` around the output of commands when they error and we include the command's output in an error string. This removes the new line from error messages and makes them more readable.
Contributor
Author
|
Merged |
xgess
reviewed
Aug 15, 2019
xgess
reviewed
Aug 15, 2019
xgess
reviewed
Aug 15, 2019
| "bin/keybaseca generate --overwrite-existing-key\n" | ||
| "echo yes | bin/keybaseca backup > /shared/cakey.backup\n" | ||
| # The output from this backup is tested in test_env_1.py | ||
| "echo yes | bin/keybaseca backup > /mnt/cakey.backup\n" |
Contributor
There was a problem hiding this comment.
can't say i love this pattern. i guess there's no way to trigger this from outside, and that's kinda the point. 🤷♂
xgess
approved these changes
Aug 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also:
keybaseca signthat verify that it generates a correct signed keykeybaseca sign(and keep the docs on doing it manually via ssh-keygen in case anything ever breaks withkeybaseca sign)keybaseca signand the signature request handler.strings.TrimSpace(...)around the output of commands when they error and we include the command's output in an error string. This removes the new line from error messages and makes them more readable.