This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Conversation
…egration tests on a machine
This reverts commit f1a039c.
ddworken
commented
Aug 15, 2019
| - image: circleci/golang:1.11 | ||
| steps: | ||
| - checkout | ||
| - run: "! go fmt ./... 2>&1 | read" |
Contributor
Author
There was a problem hiding this comment.
This trick comes from here: https://circleci.com/blog/enforce-build-standards/
Basically it is just checking whether the command outputs anything. If the command has any output, it failed.
ddworken
commented
Aug 15, 2019
|
|
||
| # Unit tests first | ||
| go test ./... 2>&1 | grep -v 'no test files' | ||
| set +u |
Contributor
Author
There was a problem hiding this comment.
So we can access $CIRCLECI which is not set if running locally.
ddworken
commented
Aug 15, 2019
| go test ./... 2>&1 | grep -v 'no test files' | ||
| set +u | ||
| if [ -z "$CIRCLECI" ]; then | ||
| go test ./... 2>&1 | grep -v 'no test files' |
Contributor
Author
There was a problem hiding this comment.
Break the go test command out into a unit test workflow so it can run in their existing go docker image (rather than having to install go on this machine in order to run it in the same image as used for the integration tests).
xgess
reviewed
Aug 15, 2019
xgess
reviewed
Aug 15, 2019
| # A context manager that asserts that the given function triggers expected_number of audit logs to be added to '/keybase/team/team.ssh.prod/ca.log' | ||
| # Note that fuse is not running in the container so this has to use `keybase fs read` | ||
| # A context manager that asserts that the given function triggers expected_number of audit logs to be added to the | ||
| # log at the given filename |
Co-Authored-By: Alex Gessner <alex.gessner@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a circle CI config that runs unit tests, integration tests, and linters.
In order to get this to work I had to move the mount location for the integration tests from
/mnt/to/shared/. Running the mount in/mnt/ran into the same weird disappearing bug that we had earlier but for whatever reason moving it to/shared/works.