This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Add golangci-lint for more linting goodness#24
Merged
Conversation
ddworken
commented
Aug 22, 2019
| log.Log(conf, fmt.Sprintf("Processing SignatureRequest from user=%s on device='%s' keyID:%s, principals:%s, expiration:%s, pubkey:%s", | ||
| sr.Username, sr.DeviceName, keyID, principals, conf.GetKeyExpiration(), sr.SSHPublicKey)) | ||
| signature, err := SignKey(conf.GetCAKeyLocation(), keyID, principals, conf.GetKeyExpiration(), sr.SSHPublicKey) | ||
| if err != nil { |
Contributor
Author
There was a problem hiding this comment.
This was actually a really good catch from it :)
joshblum
reviewed
Aug 22, 2019
| @@ -0,0 +1,8 @@ | |||
| linters: | |||
Member
There was a problem hiding this comment.
can you mirror the client settings: https://github.com/keybase/client/blob/master/go/.golangci.yml#L5-L15
Contributor
Author
There was a problem hiding this comment.
Mirrored except stricter. There are some additional linters that I have enabled that seem useful and are more practical to have enabled given that this is a smaller project. Do you object to any of the additional ones I added?
joshblum
approved these changes
Aug 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per @joshblum's suggestion, adds golangci-lint. This adds it in both the pre-commit hooks and on circle.