This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Rename module to match github repo name: bot-sshca#26
Merged
Conversation
Also fix a linting error that popped up
joshblum
approved these changes
Aug 23, 2019
Member
joshblum
left a comment
joshblum
left a comment
There was a problem hiding this comment.
lgtm assuming you manually tested setting up the repo without issue. thanks!
Contributor
Author
|
Yup! Tested manually but the circleci tests also set up integration tests (the bot, two SSH servers, and an ssh client) and test everything there. ✔️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@joshblum noticed that the name of the go module was
bot-ssh-cawhile the repo name wasbot-sshca. This didn't cause any issues (since nothing imports this code) but is still worth fixing. Just did a global find and replacebot-ssh-ca-->bot-sshca.Also fix a linting error that popped up.