Skip to content

fix add-alias modal error message style #23625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
songgao merged 2 commits into from
Apr 9, 2020
Merged

fix add-alias modal error message style #23625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36a7f34
fix add-alias modal error message style
songgao Apr 9, 2020
4a7d7ac
story
songgao Apr 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions shared/stories/__tests__/__snapshots__/Storyshots.test.js.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 1 addition & 9 deletions shared/teams/emojis/add-alias.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ export const AddAliasModal = (props: Props) => {
style={Styles.collapseStyles([!emoji && styles.opacity40])}
>
<Kb.Text type="BodySemibold">Enter an alias:</Kb.Text>
<Kb.Box2 direction="horizontal" fullWidth={true} style={styles.aliasInputContainer}>
<Kb.Box2 direction="horizontal" fullWidth={true}>
<AliasInput
ref={aliasInputRef}
error={error}
Expand Down Expand Up @@ -205,14 +205,6 @@ const emojiPadding = 4
const singleEmojiWidth = emojiWidthWithPadding - 2 * emojiPadding

const styles = Styles.styleSheetCreate(() => ({
aliasInputContainer: Styles.platformStyles({
isElectron: {
height: Styles.globalMargins.large,
},
isMobile: {
height: Styles.globalMargins.large + 3 * Styles.globalMargins.xxtiny,
},
}),
container: Styles.platformStyles({
common: {
...Styles.globalStyles.flexGrow,
Expand Down