Merged
Conversation
Replace type annotations with satisfies on const object literals across constants/fs.tsx, stores, and other config objects. This preserves narrower literal types while still validating structure at compile time.
Replace new Promise((resolve, reject) => { ... }) constructor pattern
with Promise.withResolvers() in 5 files. This flattens the code by
removing one level of nesting in callback-heavy async code.
Convert type-annotated const objects in button.tsx, icon2.tsx, avatar, router options, and inbox-rows to use satisfies.
…esolvers The installer errorTypes with satisfies narrowed booleans to literal false, causing lint errors. Reverted to type annotation. Promise.withResolvers<void>() triggers no-invalid-void-type lint rule. Changed to <undefined> and updated resolve() calls to resolve(undefined).
Relax no-invalid-void-type to allow void in all generic type arguments (was only Promise). Promise.withResolvers<void>() still triggers the rule since it's a method call not a type, so use <undefined> there.
chrisnojima
commented
Mar 7, 2026
shared/engine/listener.tsx
Outdated
| if (waitingKey) { | ||
| getEngine().dispatchWaitingAction(waitingKey, true) | ||
| } | ||
| const {promise, resolve, reject} = Promise.withResolvers() |
# Conflicts: # shared/common-adapters/icon2.tsx
Reverts back to new Promise((resolve, reject) => {...}) pattern
in all 5 files that were converted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.