Skip to content

chat refactors#29123

Merged
chrisnojima-zoom merged 59 commits intonojima/HOTPOT-next-670-clean-2from
nojima/ZCLIENT-small-chat
Apr 9, 2026
Merged

chat refactors#29123
chrisnojima-zoom merged 59 commits intonojima/HOTPOT-next-670-clean-2from
nojima/ZCLIENT-small-chat

Conversation

@chrisnojima-zoom
Copy link
Copy Markdown
Contributor

pulled non legends changes from #29023

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

@chrisnojima chrisnojima changed the title small chat changes chat refactors Apr 9, 2026
@chrisnojima chrisnojima requested a review from Copilot April 9, 2026 13:11
}
prevSuspendCount := s.suspendCount
s.suspendCount++
s.Debug(ctx, "suspend: count %d -> %d waiters: %d cancelChs: %d queued: %d",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this adds some logging. i was seeing inbox unboxing hang every once in awhile. if i restart the ui i could 100% repro this and spent a ton of time trying to see where things were going wrong (see plans/inbox-load-fail.md). after i restarted the service the problem went away and couldn't be repoed so now i think its something in the go layer

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 90 out of 92 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

This comment was marked as outdated.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 96 out of 98 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

shared/chat/conversation/messages/attachment/file.tsx:188

  • progressOverlay sets position: 'absolute' and width: 'auto', which overrides the fullWidth={true} intent on the progress container. This can cause the progress bar/label area to shrink-wrap instead of spanning the attachment row, making the progress UI hard to read. Consider removing the explicit width and using right: 0 / width: '100%' so the overlay honors full width (and optionally add padding as needed).
        {!!progressLabel && (
          <Kb.Box2 direction="horizontal" fullWidth={true} alignItems="center" style={styles.progressOverlay}>
            <Kb.Text type="BodySmall" style={styles.progressLabelStyle}>
              {progressLabel}
            </Kb.Text>
            {hasProgress && <Kb.ProgressBar ratio={progress} />}
          </Kb.Box2>
        )}

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chrisnojima-zoom chrisnojima-zoom merged commit 0c35e7d into nojima/HOTPOT-next-670-clean-2 Apr 9, 2026
4 of 5 checks passed
@chrisnojima-zoom chrisnojima-zoom deleted the nojima/ZCLIENT-small-chat branch April 9, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants