chat refactors#29123
Conversation
| } | ||
| prevSuspendCount := s.suspendCount | ||
| s.suspendCount++ | ||
| s.Debug(ctx, "suspend: count %d -> %d waiters: %d cancelChs: %d queued: %d", |
There was a problem hiding this comment.
this adds some logging. i was seeing inbox unboxing hang every once in awhile. if i restart the ui i could 100% repro this and spent a ton of time trying to see where things were going wrong (see plans/inbox-load-fail.md). after i restarted the service the problem went away and couldn't be repoed so now i think its something in the go layer
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 90 out of 92 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 96 out of 98 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
shared/chat/conversation/messages/attachment/file.tsx:188
progressOverlaysetsposition: 'absolute'andwidth: 'auto', which overrides thefullWidth={true}intent on the progress container. This can cause the progress bar/label area to shrink-wrap instead of spanning the attachment row, making the progress UI hard to read. Consider removing the explicit width and usingright: 0/width: '100%'so the overlay honors full width (and optionally add padding as needed).
{!!progressLabel && (
<Kb.Box2 direction="horizontal" fullWidth={true} alignItems="center" style={styles.progressOverlay}>
<Kb.Text type="BodySmall" style={styles.progressLabelStyle}>
{progressLabel}
</Kb.Text>
{hasProgress && <Kb.ProgressBar ratio={progress} />}
</Kb.Box2>
)}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
0c35e7d
into
nojima/HOTPOT-next-670-clean-2
pulled non legends changes from #29023