Skip to content

fixes for switching accounts on push notifications#29136

Merged
zoom-ua merged 1 commit into
masterfrom
joshblum/push-fixes
Apr 10, 2026
Merged

fixes for switching accounts on push notifications#29136
zoom-ua merged 1 commit into
masterfrom
joshblum/push-fixes

Conversation

@zoom-ua
Copy link
Copy Markdown
Contributor

@zoom-ua zoom-ua commented Apr 10, 2026

@chrisnojima @mmaxim

  • Spurious account switches on background push: Silent/background notifications were triggering account switches. Fixed by checking userInteraction before switching — only a user tap should initiate a switch.
  • Wrong-account badge updates on Android: Badge count from FCM payload was applied immediately before validating which account the push was for. Moved badge application to after Go confirms the targetUID matches the active account.
  • Push for different account crashing/logging incorrectly on Android: Added targetUID parameter to HandleBackgroundNotification in Go; Android now passes the UID and Go rejects early with a distinct error, which Kotlin logs as info rather than an error.
  • Pending push lost during account switch store reset: When switching accounts, Z.resetAllStores() was clearing the pending push notification. Now it's preserved across the reset and restored afterward.
  • Login errors leaving userSwitching flag stuck + stale pending push: On login failure, userSwitching was turned off but the pending push notification wasn't cleared. Now both are cleaned up together.
  • Push for different account arriving before configuredAccounts loads: Previously silently dropped. Now saved as pending and replayed once the account list is available.
  • OnLogin not clearing the multiple-accounts cache: Only logout cleared the cache, so a new login wouldn't reflect the updated account count until the next notification. Added OnLogin hook to clear it on both transitions.

@zoom-ua zoom-ua merged commit 4427f29 into master Apr 10, 2026
1 check passed
@zoom-ua zoom-ua deleted the joshblum/push-fixes branch April 10, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant