Skip to content

notif cleanup#29148

Merged
chrisnojima merged 4 commits intonojima/HOTPOT-next-670-clean-2from
nojima/ZCLIENT-notif-clean
Apr 15, 2026
Merged

notif cleanup#29148
chrisnojima merged 4 commits intonojima/HOTPOT-next-670-clean-2from
nojima/ZCLIENT-notif-clean

Conversation

@chrisnojima-zoom
Copy link
Copy Markdown
Contributor

move config delegation out of notif

This comment was marked as outdated.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

shared/constants/init/shared.tsx:555

  • The same condition (leaving the People tab) is checked twice in a row for two different side effects. This duplication makes it easier for the behaviors to drift if the condition ever changes. Consider combining these into a single if block that performs both clearSignupEmail() and people.markViewed() under the same guard.
      if (prev && Util.getTab(prev) === Tabs.peopleTab && next && Util.getTab(next) !== Tabs.peopleTab) {
        clearSignupEmail()
      }

      if (prev && Util.getTab(prev) === Tabs.peopleTab && next && Util.getTab(next) !== Tabs.peopleTab) {
        storeRegistry.getState('people').dispatch.markViewed()
      }

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chrisnojima chrisnojima merged commit 31c7b11 into nojima/HOTPOT-next-670-clean-2 Apr 15, 2026
5 checks passed
@chrisnojima chrisnojima deleted the nojima/ZCLIENT-notif-clean branch April 15, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants