Skip to content

remove more store plumbing#29149

Merged
chrisnojima merged 4 commits intonojima/HOTPOT-next-670-clean-2from
nojima/ZCLIENT-clean-users-updates
Apr 15, 2026
Merged

remove more store plumbing#29149
chrisnojima merged 4 commits intonojima/HOTPOT-next-670-clean-2from
nojima/ZCLIENT-clean-users-updates

Conversation

@chrisnojima-zoom
Copy link
Copy Markdown
Contributor

No description provided.

@chrisnojima chrisnojima changed the title remove users store plumbing remove more store plumbing Apr 15, 2026
@chrisnojima chrisnojima requested a review from Copilot April 15, 2026 15:58
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR continues the “remove store plumbing” effort by eliminating several dispatch.defer.* callback hooks and replacing them with direct reads/dispatches to the relevant Zustand stores (e.g., useUsersState, useDaemonState, useSettingsContactsState). This reduces initialization-time wiring in shared/constants/init/shared.tsx and makes the updated stores more self-sufficient.

Changes:

  • Removed multiple dispatch.defer.* callback contracts (push handshake, users updates/info map, team-building settings/users hooks).
  • Updated chat, teams, tracker, and team-building stores to directly call into useUsersState, useDaemonState, and useSettingsContactsState.
  • Simplified shared init by deleting now-unneeded callback initializers and updated the desktop push store test accordingly.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
shared/stores/tracker.tsx Removes deferred onUsersUpdates plumbing; updates users via useUsersState directly.
shared/stores/tests/push.desktop.test.ts Updates test to stop asserting removed handshake defer behavior.
shared/stores/teams.tsx Removes deferred users-updates callback; pushes member fullname updates via useUsersState.
shared/stores/team-building.tsx Removes deferred settings/users hooks; reads settings-contacts state and dispatches users updates/block state directly.
shared/stores/push.native.tsx Replaces daemon handshake defer callback with direct useDaemonState handshakeState check.
shared/stores/push.desktop.tsx Removes now-unused defer.onGetDaemonHandshakeState stub.
shared/stores/push.d.ts Updates Push store typings to remove dispatch.defer handshake accessor.
shared/stores/chat.tsx Removes daemon/users defer accessors; uses useDaemonState / useUsersState directly.
shared/constants/init/shared.tsx Deletes init callback wiring for removed defers (push/tracker/users/team-building settings/users).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chrisnojima chrisnojima merged commit 27702db into nojima/HOTPOT-next-670-clean-2 Apr 15, 2026
1 check passed
@chrisnojima chrisnojima deleted the nojima/ZCLIENT-clean-users-updates branch April 15, 2026 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants