font cleanup#29198
Merged
chrisnojima merged 27 commits intonojima/HOTPOT-next-670-clean-2from May 7, 2026
Merged
Conversation
chrisnojima
commented
May 7, 2026
| navigation: {canGoBack: () => boolean} | ||
| }): NativeStackNavigationOptions => ({ | ||
| ...Common.defaultNavigationOptions, | ||
| ...(Platform.OS === 'ios' ? {contentStyle: {backgroundColor: Kb.Styles.globalColors.whiteOrBlack}} : {}), |
… parser Two bugs in _build_icon_glyph / _draw_svg_path: 1. Transform accumulation walked ancestor <g> elements but ignored transform= on the <path> element itself. Unhide and coin-flip SVGs carry translate(-1) / translate(-3 -2) on their <path>, not on <g>, so the translate was silently skipped, placing those glyphs 1-3px right of their intended position and extending past the advance width. Fix: start the ancestor walk at elem itself, not its parent. 2. Implicit command repetition in the C/c branch tried to parse a command letter as a float when fewer than 6 numbers remained before the next command (e.g. "c ... .06 -.119 .109 -.456 s ..."). The has_nums(n) guard now stops the implicit repeat at command letters.
Some SVGs have content that extends slightly beyond their stated viewBox (e.g. unhide extends 1px on each side). Scale such glyphs down uniformly around the horizontal center so they fit cleanly within [0, advance_width].
chrisnojima
merged commit aa96cc1
into
nojima/HOTPOT-next-670-clean-2
1 check was pending
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the old fontforge + webfonts-generator pipeline with a pure-Python font_tool.py that builds kb.ttf directly from SVGs using fonttools.
shared/tools/fonts/): new build tool — parses SVG paths, assembles glyph outlines, sets OS/2 and GASP metrics, and writes platform-specific TTF outputs (root, ios/, electron/, android/) fromfonts/manifest.jsonfonts/manifest.json,fonts/metrics.json): declarative config for text fonts and icon font, plus snapshotted metrics for regression checkingfonts/ios/,fonts/electron/,fonts/android/subdirs; Xcode and webpack updated to point at new pathsfonts/android/fixes.py(fontforge underline-pos fix, now handled viaandroidPatchesin manifest),update-icon-font/update-web-fontyarn scripts, all fontforge/webfonts-generator code fromdesktop/yarn-helper/font.mts