electron legends list#29225
Merged
chrisnojima merged 13 commits intoMay 20, 2026
Merged
Conversation
LegendList's scrollToIndex uses estimated item positions for unrendered items, causing it to land far from the target when estimated sizes are smaller than actual. Fix by adding data-ordinal to each row and using a retry loop: attempt scrollIntoView on the element directly, falling back to scrollToIndex to get closer each time until the element is rendered. Also extract HighlightableRow so it subscribes to the center context directly, ensuring re-renders propagate through LegendList's recycled containers. Disable maintainVisibleContentPosition during centering to prevent it from fighting the scroll.
Comment on lines
309
to
317
| <div | ||
| data-testid="message-list" | ||
| style={Kb.Styles.castStyleDesktop(desktopStyles.container)} | ||
| onClick={handleListClick} | ||
| onCopyCapture={onCopyCapture} | ||
| ref={wrapperRef} | ||
| > | ||
| <div | ||
| data-testid="message-list" | ||
| className="chat-scroller" | ||
| <LegendList | ||
| key={conversationIDKey} |
Comment on lines
186
to
+193
| React.useEffect(() => { | ||
| const wasLoaded = wasLoadedRef.current | ||
| const changed = prevCenteredOrdinal.current !== centeredOrdinal | ||
| prevCenteredOrdinal.current = centeredOrdinal | ||
| wasLoadedRef.current = loaded | ||
|
|
||
| // Only scroll if we were already loaded and ordinal changed | ||
| // (the load effect handles scrolling when loaded transitions to true) | ||
| if (!wasLoaded || !loaded || !changed) return | ||
|
|
||
| if (!loaded) return | ||
| if (centeredOrdinal) { | ||
| lockedToBottomRef.current = false | ||
| scrollToCentered() | ||
| } else if (containsLatestMessage) { | ||
| lockedToBottomRef.current = true | ||
| scrollToBottom() | ||
| if (lastScrolledCenteredRef.current === centeredOrdinal) return | ||
| const idx = sortedIndexOf(messageOrdinalsRef.current as unknown as number[], centeredOrdinal as unknown as number) | ||
| if (idx < 0) return | ||
| lastScrolledCenteredRef.current = centeredOrdinal | ||
| const target = centeredOrdinal |
| | null | ||
| )?.querySelector(`[data-ordinal="${target}"]`) | ||
| if (el) { | ||
| el.scrollIntoView({behavior: 'instant', block: 'center'}) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.