keyboard send fix#29235
Merged
chrisnojima merged 2 commits intoMay 22, 2026
Merged
Conversation
…ard open When the keyboard is open, KeyboardChatScrollView sets contentOffset.y = -(K-I) via contentInset.top. Three issues caused the list to shift on send: 1. scrollToBottom scrolled to offset=0 instead of -(K-I) 2. maintainVisibleContentPosition autoscrollToTopThreshold=1 fired (-(K-I) <= 1) and scrolled to y=0, stripping the keyboard offset 3. MPV's per-insertion offset adjustment added message_height to contentOffset, creating a gap between the newest message and the input area Fix: compute the correct keyboard-aware offset in scrollToBottom, disable MPV entirely when the keyboard is visible (new messages appear naturally at the contentInset boundary), and add a layout-effect safety net that re-scrolls to bottom when new messages arrive while the keyboard is open.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.