Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
ac2d175
docs: add border() helper + style analysis skill design spec
chrisnojima May 26, 2026
800dddd
feat: add Kb.Styles.border() helper
chrisnojima May 26, 2026
36cdb9c
feat: add style analysis script (extract + analyze phases)
chrisnojima May 26, 2026
687c86d
feat: add keybase-style-analysis skill and implementation plan
chrisnojima May 26, 2026
81aadcc
refactor: apply Kb.Styles.border() in chat/audio and chat/conversation
chrisnojima May 26, 2026
652a94c
refactor: apply Kb.Styles.border() in devices and provision
chrisnojima May 26, 2026
4f9c3ee
refactor: apply Kb.Styles.border() in chat/emoji-picker and common-ad…
chrisnojima May 26, 2026
5f30dfd
refactor: apply Kb.Styles.border() in teams
chrisnojima May 26, 2026
b0b6a3f
docs: remove border helper plan and spec docs
chrisnojima May 26, 2026
c17319c
WIP
chrisnojima May 26, 2026
199a91a
feat: add topDivider, roundedBottom, textEllipsis, paddingH/V, margin…
chrisnojima May 26, 2026
e6e6c0b
feat: add gap detection for topDivider, roundedBottom, textEllipsis, …
chrisnojima May 26, 2026
0296424
refactor: apply Kb.Styles.topDivider()
chrisnojima May 26, 2026
203afaf
refactor: apply Kb.Styles.roundedBottom()
chrisnojima May 26, 2026
f17d874
refactor: apply Kb.Styles.textEllipsis
chrisnojima May 26, 2026
109fb16
refactor: apply Kb.Styles.paddingH()
chrisnojima May 26, 2026
dbe98ff
refactor: apply Kb.Styles.paddingV()
chrisnojima May 26, 2026
2af0586
refactor: apply Kb.Styles.marginH()
chrisnojima May 26, 2026
ebb8ffe
fix: exclude string margin values from marginH gap detector
chrisnojima May 26, 2026
4910e81
refactor: apply Kb.Styles.marginV()
chrisnojima May 26, 2026
6a6c5fc
refactor: apply Kb.Styles.marginV() at remaining wrapper.tsx site
chrisnojima May 26, 2026
4a1bfa2
fix: widen size() to accept percentage strings; exclude undefined fro…
chrisnojima May 26, 2026
9c75d09
refactor: apply Kb.Styles.size()
chrisnojima May 26, 2026
e1eb2f2
fix: add new style helpers to Styles mock in confirm.test.tsx
chrisnojima May 26, 2026
9df4b02
WIP
chrisnojima May 26, 2026
15bc643
WIP
chrisnojima May 26, 2026
f31e070
WIP
chrisnojima May 26, 2026
d4f86c4
WIP
chrisnojima May 26, 2026
692c1ee
WIP
chrisnojima May 26, 2026
163bc2e
fix LegendList deadlock when cached thread data arrives before onLayo…
chrisnojima May 27, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions shared/app/global-errors.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -304,9 +304,8 @@ const styles = Kb.Styles.styleSheetCreate(() => {
flexGrow: 0,
},
mobileSummaryRow: {
alignItems: 'center',
...Kb.Styles.centered(),
flexShrink: 0,
justifyContent: 'center',
...Kb.Styles.padding(Kb.Styles.globalMargins.tiny, Kb.Styles.globalMargins.xsmall),
},
overlayFill: {
Expand Down
5 changes: 1 addition & 4 deletions shared/chat/audio/audio-player.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -119,11 +119,8 @@ const AudioPlayer = (props: Props) => {
const styles = Kb.Styles.styleSheetCreate(() => ({
container: {
...Kb.Styles.padding(Kb.Styles.globalMargins.xxtiny, Kb.Styles.globalMargins.tiny),
...Kb.Styles.border(Kb.Styles.globalColors.grey, 1, Kb.Styles.borderRadius),
backgroundColor: Kb.Styles.globalColors.white,
borderColor: Kb.Styles.globalColors.grey,
borderRadius: Kb.Styles.borderRadius,
borderStyle: 'solid',
borderWidth: 1,
},
visContainer: {
alignItems: 'flex-start',
Expand Down
6 changes: 2 additions & 4 deletions shared/chat/audio/audio-recorder.native.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -853,16 +853,14 @@ const styles = Kb.Styles.styleSheetCreate(() => ({
iconStyle: {padding: Kb.Styles.globalMargins.tiny},
innerCircleStyle: {
...circleAroundIcon(84),
alignItems: 'center',
justifyContent: 'center',
...Kb.Styles.centered(),
},
lockHintStyle: {
...centerAroundIcon(32),
},
sendRecordingButtonStyle: {
...circleAroundIcon(32),
alignItems: 'center',
justifyContent: 'center',
...Kb.Styles.centered(),
},
tooltipContainer: {
backgroundColor: Kb.Styles.globalColors.black,
Expand Down
9 changes: 3 additions & 6 deletions shared/chat/audio/audio-send.native.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -59,18 +59,15 @@ const styles = Kb.Styles.styleSheetCreate(() => ({
borderStyle: 'solid',
borderTopColor: Kb.Styles.globalColors.black_10,
borderTopWidth: 1,
paddingLeft: Kb.Styles.globalMargins.tiny,
paddingRight: Kb.Styles.globalMargins.tiny,
...Kb.Styles.paddingH(Kb.Styles.globalMargins.tiny),
},
icon: {
height: 32,
...Kb.Styles.size(32),
marginRight: Kb.Styles.globalMargins.tiny,
width: 32,
},
send: {
alignSelf: 'flex-end',
marginBottom: Kb.Styles.globalMargins.tiny,
marginTop: Kb.Styles.globalMargins.tiny,
...Kb.Styles.marginV(Kb.Styles.globalMargins.tiny),
},
}))

Expand Down
15 changes: 4 additions & 11 deletions shared/chat/blocking/block-modal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -527,12 +527,10 @@ const styles = Kb.Styles.styleSheetCreate(() => ({
iconBox: {paddingLeft: Kb.Styles.globalMargins.tiny},
loadingAnimation: Kb.Styles.platformStyles({
isElectron: {
height: 32,
width: 32,
...Kb.Styles.size(32),
},
isMobile: {
height: 48,
width: 48,
...Kb.Styles.size(48),
},
}),
loadingAnimationBox: {
Expand All @@ -542,15 +540,10 @@ const styles = Kb.Styles.styleSheetCreate(() => ({
modalFooter: Kb.Styles.platformStyles({
common: {
...Kb.Styles.padding(Kb.Styles.globalMargins.xsmall, Kb.Styles.globalMargins.small),
borderStyle: 'solid' as const,
borderTopColor: Kb.Styles.globalColors.black_10,
borderTopWidth: 1,
minHeight: 56,
...Kb.Styles.topDivider(),
},
isElectron: {
borderBottomLeftRadius: Kb.Styles.borderRadius,
borderBottomRightRadius: Kb.Styles.borderRadius,
overflow: 'hidden',
...Kb.Styles.roundedBottom(),
},
}),
radioButton: {marginLeft: Kb.Styles.globalMargins.large},
Expand Down
27 changes: 9 additions & 18 deletions shared/chat/conversation/attachment-fullscreen/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -414,15 +414,13 @@ const styles = Kb.Styles.styleSheetCreate(
circle: Kb.Styles.platformStyles({
isElectron: {
...Kb.Styles.globalStyles.flexBoxColumn,
alignItems: 'center',
...Kb.Styles.centered(),
alignSelf: 'center',
borderRadius: 36,
cursor: 'pointer',
flexShrink: 0,
height: 36,
justifyContent: 'center',
...Kb.Styles.size(36),
margin: Kb.Styles.globalMargins.small,
width: 36,
},
}),
close: Kb.Styles.platformStyles({
Expand All @@ -434,8 +432,7 @@ const styles = Kb.Styles.styleSheetCreate(
contentsFit: {
...Kb.Styles.globalStyles.flexBoxRow,
flex: 1,
height: '100%',
width: '100%',
...Kb.Styles.size('100%'),
},
disabled: {opacity: 0.3},
ellipsisContainer: Kb.Styles.platformStyles({
Expand All @@ -444,8 +441,7 @@ const styles = Kb.Styles.styleSheetCreate(
error: {color: Kb.Styles.globalColors.redDark},
headerFooter: Kb.Styles.platformStyles({
common: {
paddingLeft: Kb.Styles.globalMargins.tiny,
paddingRight: Kb.Styles.globalMargins.tiny,
...Kb.Styles.paddingH(Kb.Styles.globalMargins.tiny),
},
isElectron: {
alignItems: 'center',
Expand All @@ -457,10 +453,9 @@ const styles = Kb.Styles.styleSheetCreate(
backgroundColor: Kb.Styles.globalColors.blackOrBlack,
bottom: Kb.Styles.globalMargins.small,
flexShrink: 0,
height: 34,
...Kb.Styles.size(34),
left: Kb.Styles.globalMargins.small,
position: 'absolute',
width: 34,
zIndex: 3,
},
}),
Expand All @@ -480,26 +475,22 @@ const styles = Kb.Styles.styleSheetCreate(
isElectron: {
cursor: 'normal',
display: 'block',
height: '100%',
...Kb.Styles.size('100%'),
objectFit: 'scale-down' as const,
width: '100%',
},
}),
videoWrapper: Kb.Styles.platformStyles({
isMobile: {
alignItems: 'center',
height: '100%',
justifyContent: 'center',
...Kb.Styles.centered(),
...Kb.Styles.size('100%'),
position: 'relative',
width: '100%',
},
}),
zoomableBox: Kb.Styles.platformStyles({
isMobile: {
backgroundColor: Kb.Styles.globalColors.blackOrBlack,
height: '100%',
...Kb.Styles.size('100%'),
position: 'relative',
width: '100%',
},
}),
}) as const
Expand Down
11 changes: 3 additions & 8 deletions shared/chat/conversation/attachment-get-titles.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -267,8 +267,7 @@ const styles = Kb.Styles.styleSheetCreate(
common: {
alignItems: 'center',
flexGrow: 1,
paddingLeft: Kb.Styles.globalMargins.small,
paddingRight: Kb.Styles.globalMargins.small,
...Kb.Styles.paddingH(Kb.Styles.globalMargins.small),
width: '100%',
},
isMobile: {flexShrink: 1},
Expand Down Expand Up @@ -299,10 +298,7 @@ const styles = Kb.Styles.styleSheetCreate(
},
input: Kb.Styles.platformStyles({
common: {
borderColor: Kb.Styles.globalColors.blue,
borderRadius: Kb.Styles.borderRadius,
borderStyle: 'solid',
borderWidth: 1,
...Kb.Styles.border(Kb.Styles.globalColors.blue, 1, Kb.Styles.borderRadius),
maxHeight: 42,
minHeight: 42,
padding: Kb.Styles.globalMargins.tiny,
Expand All @@ -321,8 +317,7 @@ const styles = Kb.Styles.styleSheetCreate(
},
inputContainer: Kb.Styles.platformStyles({
isElectron: {
paddingLeft: Kb.Styles.globalMargins.small,
paddingRight: Kb.Styles.globalMargins.small,
...Kb.Styles.paddingH(Kb.Styles.globalMargins.small),
},
}),
}) as const
Expand Down
3 changes: 1 addition & 2 deletions shared/chat/conversation/bot/channel-picker.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -167,8 +167,7 @@ const styles = Kb.Styles.styleSheetCreate(
marginTop: Kb.Styles.globalMargins.tiny,
},
isElectron: {
marginLeft: Kb.Styles.globalMargins.small,
marginRight: Kb.Styles.globalMargins.small,
...Kb.Styles.marginH(Kb.Styles.globalMargins.small),
},
}),
}) as const
Expand Down
9 changes: 2 additions & 7 deletions shared/chat/conversation/bot/install.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -816,15 +816,10 @@ const styles = Kb.Styles.styleSheetCreate(() => ({
modalFooter: Kb.Styles.platformStyles({
common: {
...Kb.Styles.padding(Kb.Styles.globalMargins.xsmall, Kb.Styles.globalMargins.small),
borderStyle: 'solid' as const,
borderTopColor: Kb.Styles.globalColors.black_10,
borderTopWidth: 1,
minHeight: 56,
...Kb.Styles.topDivider(),
},
isElectron: {
borderBottomLeftRadius: Kb.Styles.borderRadius,
borderBottomRightRadius: Kb.Styles.borderRadius,
overflow: 'hidden',
...Kb.Styles.roundedBottom(),
},
}),
outerContainer: Kb.Styles.platformStyles({
Expand Down
6 changes: 2 additions & 4 deletions shared/chat/conversation/bot/team-picker.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,7 @@ const styles = Kb.Styles.styleSheetCreate(
}),
results: Kb.Styles.platformStyles({
common: {
paddingLeft: Kb.Styles.globalMargins.tiny,
paddingRight: Kb.Styles.globalMargins.tiny,
...Kb.Styles.paddingH(Kb.Styles.globalMargins.tiny),
},
isMobile: {
paddingBottom: Kb.Styles.globalMargins.tiny,
Expand All @@ -115,8 +114,7 @@ const styles = Kb.Styles.styleSheetCreate(
marginTop: Kb.Styles.globalMargins.tiny,
},
isElectron: {
marginLeft: Kb.Styles.globalMargins.small,
marginRight: Kb.Styles.globalMargins.small,
...Kb.Styles.marginH(Kb.Styles.globalMargins.small),
},
}),
}) as const
Expand Down
8 changes: 2 additions & 6 deletions shared/chat/conversation/bottom-banner.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -173,14 +173,10 @@ const styles = Kb.Styles.styleSheetCreate(
bannerStyle: Kb.Styles.platformStyles({
common: {
...Kb.Styles.globalStyles.flexBoxColumn,
alignItems: 'center',
...Kb.Styles.centered(),
backgroundColor: Kb.Styles.globalColors.red,
flexWrap: 'wrap',
justifyContent: 'center',
paddingBottom: 8,
paddingLeft: 24,
paddingRight: 24,
paddingTop: 8,
...Kb.Styles.padding(8, 24),
},
isElectron: {
marginBottom: Kb.Styles.globalMargins.tiny,
Expand Down
9 changes: 3 additions & 6 deletions shared/chat/conversation/fwd-msg.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -285,14 +285,12 @@ const styles = Kb.Styles.styleSheetCreate(
}),
inputContainer: Kb.Styles.platformStyles({
isElectron: {
paddingLeft: Kb.Styles.globalMargins.small,
paddingRight: Kb.Styles.globalMargins.small,
...Kb.Styles.paddingH(Kb.Styles.globalMargins.small),
},
}),
results: Kb.Styles.platformStyles({
common: {
paddingLeft: Kb.Styles.globalMargins.tiny,
paddingRight: Kb.Styles.globalMargins.tiny,
...Kb.Styles.paddingH(Kb.Styles.globalMargins.tiny),
},
isMobile: {paddingBottom: Kb.Styles.globalMargins.tiny},
}),
Expand All @@ -302,8 +300,7 @@ const styles = Kb.Styles.styleSheetCreate(
marginTop: Kb.Styles.globalMargins.tiny,
},
isElectron: {
marginLeft: Kb.Styles.globalMargins.small,
marginRight: Kb.Styles.globalMargins.small,
...Kb.Styles.marginH(Kb.Styles.globalMargins.small),
},
}),
}) as const
Expand Down
3 changes: 1 addition & 2 deletions shared/chat/conversation/giphy/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,7 @@ const styles = Kb.Styles.styleSheetCreate(
instructions: Kb.Styles.platformStyles({
common: {
alignSelf: 'center',
paddingBottom: Kb.Styles.globalMargins.tiny,
paddingTop: Kb.Styles.globalMargins.tiny,
...Kb.Styles.paddingV(Kb.Styles.globalMargins.tiny),
},
isElectron: {
lineHeight: 17,
Expand Down
2 changes: 1 addition & 1 deletion shared/chat/conversation/header-area/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -319,6 +319,6 @@ const styles = Kb.Styles.styleSheetCreate(
alignItems: 'center',
},
shhIcon: {marginLeft: Kb.Styles.globalMargins.xtiny},
usernameHeaderContainer: {alignItems: 'center', justifyContent: 'center'},
usernameHeaderContainer: Kb.Styles.centered(),
}) as const
)
9 changes: 2 additions & 7 deletions shared/chat/conversation/info-panel/add-to-channel.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -183,15 +183,10 @@ const styles = Kb.Styles.styleSheetCreate(() => ({
modalFooter: Kb.Styles.platformStyles({
common: {
...Kb.Styles.padding(Kb.Styles.globalMargins.xsmall, Kb.Styles.globalMargins.small),
borderStyle: 'solid' as const,
borderTopColor: Kb.Styles.globalColors.black_10,
borderTopWidth: 1,
minHeight: 56,
...Kb.Styles.topDivider(),
},
isElectron: {
borderBottomLeftRadius: Kb.Styles.borderRadius,
borderBottomRightRadius: Kb.Styles.borderRadius,
overflow: 'hidden',
...Kb.Styles.roundedBottom(),
},
}),
}))
Expand Down
3 changes: 1 addition & 2 deletions shared/chat/conversation/info-panel/header.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -192,8 +192,7 @@ const styles = Kb.Styles.styleSheetCreate(
gear: Kb.Styles.platformStyles({
common: {
height: gearIconSize,
paddingLeft: 16,
paddingRight: 16,
...Kb.Styles.paddingH(16),
},
isMobile: {width: gearIconSize + 32},
}),
Expand Down
Loading