Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

openpgp: ignore unsupported critical packets on cross-signed WoT sigs#17

Merged
maxtaco merged 2 commits intomasterfrom
maxtaco/CORE-2634
Feb 29, 2016
Merged

openpgp: ignore unsupported critical packets on cross-signed WoT sigs#17
maxtaco merged 2 commits intomasterfrom
maxtaco/CORE-2634

Conversation

@maxtaco
Copy link

@maxtaco maxtaco commented Feb 29, 2016

Fixes keybase id sneak

@maxtaco
Copy link
Author

maxtaco commented Feb 29, 2016

r? @oconnor663

openpgp/keys.go Outdated
case *packet.Signature:

// First handle the case of a self-signature. According to RFC8440,
// These are signatures but other people on this key. Let's just ignore them

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/but/by/

@oconnor663
Copy link

lgtm

maxtaco added a commit that referenced this pull request Feb 29, 2016
openpgp: ignore unsupported critical packets on cross-signed WoT sigs
@maxtaco maxtaco merged commit c9f75da into master Feb 29, 2016
@maxtaco maxtaco deleted the maxtaco/CORE-2634 branch February 29, 2016 15:42
@dolmen
Copy link

dolmen commented Jun 15, 2017

Has it been submitted upstream?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants