Mutable fields#3
Closed
keyboardDrummer wants to merge 153 commits intoforJVerifyfrom
Closed
Conversation
fabiomadge
reviewed
Jan 19, 2026
| " | ||
|
|
||
| #guard_msgs(drop info, error) in | ||
| #eval! testInputWithOffset "T5_ProcedureCallsBoogie" program 20 processLaurelFile |
fabiomadge
reviewed
Jan 19, 2026
| - It has no precondition (or just `true`) | ||
| - It has exactly one output parameter (the return type) | ||
| -/ | ||
| def canBeBoogieFunction (proc : Procedure) : Bool := |
### Changes 1. Move Laurel grammar from a `.lean` into a `.st` file, so it can be consumed by the `javaGen` command 1. Do not let the Laurel grammar use `fn` or `type`, since those are not needed and are not supported by `javaGen` 1. For source code positions, store byte code array offsets in the AST nodes, so that when parsing programs from Ion, these can be filled in without having access to original source files 1. Enable the Ion deserialization code to deserialize multiple files where each file has a filepath and a program AST. 1. Add a `laurelAnalyze` command to StrataMain that for now will serve as a root for Laurel related interactions. I can imagine that in the future we will introduce an analyze command that is agnostic to the dialect used. ### Testing - Laurel pipeline changes (1-3) are covered by existing tests - (4) Added a test for the newly introduced `Ion.fromIonFiles` - (5) No test added, although I've successfully used this command from strata-org/jverify#372 --------- Co-authored-by: Fabio Madge <fmadge@amazon.com> Co-authored-by: Fabio Madge <fabio@madge.me> Co-authored-by: Joe Hendrix <joehx@amazon.com>
keyboardDrummer
added a commit
that referenced
this pull request
Feb 13, 2026
### Changes - Add a Python script in `Tools` that enables automatically updating the results of `#guard_msg` - Update formatting of applications in Core. A good way to see how the formatting has changed is to look at the updated tests in this PR. Before: ``` while (((~Int.Lt i) n)) (some ((~Int.Sub n) i)) (some ((~Bool.And ((~Int.Le i) n)) (((~Int.Div ((~Int.Mul i) ((~Int.Sub i) #1))) #2) == sum))) {sum := ((~Int.Add sum) i) i := ((~Int.Add i) #1)} ``` After: ``` while (~Int.Lt i n) (some (~Int.Sub n i)) (some (~Bool.And (~Int.Le i n) ((~Int.Div (~Int.Mul i (~Int.Sub i #1)) #2) == sum))) { sum := (~Int.Add sum i) i := (~Int.Add i #1) } ``` Applications in expressions require fewer parenthesis are are shown in a tree like fashion when they do not fit on a line: Before ``` /-- info: Annotated expression: ((((~List$Elim : (arrow (List (Tup int string)) (arrow int (arrow (arrow (Tup int string) (arrow (List (Tup int string)) (arrow int int))) int)))) (((~Cons : (arrow (Tup int string) (arrow (List (Tup int string)) (List (Tup int string))))) (((~Prod : (arrow int (arrow string (Tup int string)))) #3) #a)) (((~Cons : (arrow (Tup int string) (arrow (List (Tup int string)) (List (Tup int string))))) (((~Prod : (arrow int (arrow string (Tup int string)))) #4) #b)) (~Nil : (List (Tup int string)))))) #0) (λ (λ (λ (((~Int.Add : (arrow int (arrow int int))) (((~Tup$Elim : (arrow (Tup int string) (arrow (arrow int (arrow string int)) int))) %2) (λ (λ %1)))) ((((~List$Elim : (arrow (List (Tup int string)) (arrow int (arrow (arrow (Tup int string) (arrow (List (Tup int string)) (arrow int int))) int)))) %1) #1) (λ (λ (λ (((~Tup$Elim : (arrow (Tup int string) (arrow (arrow int (arrow string int)) int))) %2) (λ (λ %1)))))))))))) ``` After ``` /-- info: Annotated expression: ((~List$Elim : (arrow (List (Tup int string)) (arrow int (arrow (arrow (Tup int string) (arrow (List (Tup int string)) (arrow int int))) int)))) ((~Cons : (arrow (Tup int string) (arrow (List (Tup int string)) (List (Tup int string))))) ((~Prod : (arrow int (arrow string (Tup int string)))) #3 #a) ((~Cons : (arrow (Tup int string) (arrow (List (Tup int string)) (List (Tup int string))))) ((~Prod : (arrow int (arrow string (Tup int string)))) #4 #b) (~Nil : (List (Tup int string))))) #0 (λ (λ (λ ((~Int.Add : (arrow int (arrow int int))) ((~Tup$Elim : (arrow (Tup int string) (arrow (arrow int (arrow string int)) int))) %2 (λ (λ %1))) ((~List$Elim : (arrow (List (Tup int string)) (arrow int (arrow (arrow (Tup int string) (arrow (List (Tup int string)) (arrow int int))) int)))) %1 #1 (λ (λ (λ ((~Tup$Elim : (arrow (Tup int string) (arrow (arrow int (arrow string int)) int))) %2 (λ (λ %1)))))))))))) ``` ### Testing Updated tests --------- Co-authored-by: Andrew Wells <130512013+andrewmwells-amazon@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Testing
T1_MutableFields.lean