chore: list workspace members explicitly to prevent stub-dir blowup#115
Merged
Conversation
packages/* glob matches any directory on the filesystem, including leftover dirs from branch checkouts and half-bootstrapped stubs that lack pyproject.toml. uv 0.11.7 silently skips them but other tooling does not. Switch to an explicit member list so the workspace is a closed set regardless of what exists under packages/. Also updates DEVELOPER.md new-package checklist to reflect the three-step registration process.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/*workspace glob with an explicit list of active package directoriespackages/*/examples/*glob because current example projects each havepyproject.tomlDEVELOPER.mdso new packages are explicitly registered in the workspace and sourcesWhy
A broad top-level
packages/*glob can sweep in stale branch leftovers or half-bootstrapped package dirs that do not havepyproject.toml. This checkout already has ignoredpackages/agentsandpackages/crewaidirectories, which matches the class of workspace failure Matte flagged.Listing active top-level packages explicitly makes the workspace package set closed and predictable while preserving the existing examples behavior.
Verified
uv lock --checkuv build --all-packages --out-dir /private/tmp/keycard-build-checkNotes
keycardai-crewaiwork should add"packages/crewai"to[tool.uv.workspace] memberswhen that package is ready to join the workspace.