feat(keycardai-oauth): detailed error reporting#80
Merged
kamil-keycard merged 5 commits intomainfrom Mar 6, 2026
Merged
Conversation
cmars
approved these changes
Mar 6, 2026
cmars
left a comment
cmars
left a comment
There was a problem hiding this comment.
LGTM!
As this is an API breaking change (reasonable for a 0.x minor version bump) I'd suggest adding something about the API change to the release notes. This might be handled by release automation but I wasn't sure.
📦 Release PreviewThis analysis shows the expected release impact: 📈 Expected Version Changes📋 Package Details[
{
"package_name": "keycardai-mcp",
"package_dir": "packages/mcp",
"has_changes": true,
"current_version": "0.20.1",
"next_version": "0.21.0",
"increment": "MINOR"
},
{
"package_name": "keycardai-oauth",
"package_dir": "packages/oauth",
"has_changes": true,
"current_version": "0.6.0",
"next_version": "0.7.0",
"increment": "MINOR"
},
{
"package_name": "keycardai-mcp-fastmcp",
"package_dir": "packages/mcp-fastmcp",
"has_changes": true,
"current_version": "0.18.1",
"next_version": "0.19.0",
"increment": "MINOR"
}
]📝 Changelog PreviewThis comment was automatically generated by the release preview workflow. |
kamil-keycard
force-pushed
the
kamil/detail-token-exchange-errors
branch
from
98b844f to
302f1d1
Compare
📦 Release PreviewThis analysis shows the expected release impact: 📈 Expected Version Changes📋 Package Details[
{
"package_name": "keycardai-mcp",
"package_dir": "packages/mcp",
"has_changes": true,
"current_version": "0.20.1",
"next_version": "0.21.0",
"increment": "MINOR"
},
{
"package_name": "keycardai-oauth",
"package_dir": "packages/oauth",
"has_changes": true,
"current_version": "0.6.0",
"next_version": "0.7.0",
"increment": "MINOR"
},
{
"package_name": "keycardai-mcp-fastmcp",
"package_dir": "packages/mcp-fastmcp",
"has_changes": true,
"current_version": "0.18.1",
"next_version": "0.19.0",
"increment": "MINOR"
}
]📝 Changelog PreviewThis comment was automatically generated by the release preview workflow. |
kamil-keycard
force-pushed
the
kamil/detail-token-exchange-errors
branch
from
302f1d1 to
80b480d
Compare
📦 Release PreviewThis analysis shows the expected release impact: 📈 Expected Version Changes📋 Package Details[
{
"package_name": "keycardai-mcp",
"package_dir": "packages/mcp",
"has_changes": true,
"current_version": "0.20.1",
"next_version": "0.21.0",
"increment": "MINOR"
},
{
"package_name": "keycardai-oauth",
"package_dir": "packages/oauth",
"has_changes": true,
"current_version": "0.6.0",
"next_version": "0.7.0",
"increment": "MINOR"
},
{
"package_name": "keycardai-mcp-fastmcp",
"package_dir": "packages/mcp-fastmcp",
"has_changes": true,
"current_version": "0.18.1",
"next_version": "0.19.0",
"increment": "MINOR"
}
]📝 Changelog PreviewThis comment was automatically generated by the release preview workflow. |
Collaborator
Author
|
I was hoping the comitizer will pickup the conventional commits, but it didn't . The manual breaking changes added to the notes. |
BREAKING CHANGE: Token exchange HTTP 4xx errors with structured JSON bodies now raise OAuthProtocolError instead of OAuthHttpError. Callers catching OAuthHttpError for these responses must update to catch OAuthProtocolError.
… chain Restructure error dicts to remove redundancy and improve readability. Key renames: error->message, error_code->code, error_description->description, resource_errors->resources. Only include raw_error for non-OAuth exceptions. BREAKING CHANGE: Error dict keys renamed: error->message, error_code->code, error_description->description. The get_errors() output key resource_errors is now resources.
…exchange chain Restructure error dicts to remove redundancy and improve readability. Key renames: error->message, error_code->code, error_description->description, resource_errors->resources. Only include raw_error for non-OAuth exceptions. BREAKING CHANGE: Error dict keys renamed: error->message, error_code->code, error_description->description. The get_errors() output key resource_errors is now resources.
…ructured error bodies
kamil-keycard
force-pushed
the
kamil/detail-token-exchange-errors
branch
from
80b480d to
9526566
Compare
📦 Release PreviewThis analysis shows the expected release impact: 📈 Expected Version Changes📋 Package Details[
{
"package_name": "keycardai-mcp",
"package_dir": "packages/mcp",
"has_changes": true,
"current_version": "0.20.1",
"next_version": "0.21.0",
"increment": "MINOR"
},
{
"package_name": "keycardai-oauth",
"package_dir": "packages/oauth",
"has_changes": true,
"current_version": "0.6.0",
"next_version": "0.7.0",
"increment": "MINOR"
},
{
"package_name": "keycardai-mcp-fastmcp",
"package_dir": "packages/mcp-fastmcp",
"has_changes": true,
"current_version": "0.18.1",
"next_version": "0.19.0",
"increment": "MINOR"
}
]📝 Changelog PreviewThis comment was automatically generated by the release preview workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detailed error reporting to provide consumers with policy violation information.
This enables agents to report which policies caused the denial, instead of the old Token Exchange error