Separate timeout from fail in attestation summary and timeline#90
Merged
sarroutbi merged 1 commit intoMay 12, 2026
Conversation
Timeout (push-mode state 103) was grouped with Fail (101) as a single "failed" category. The SRS (FR-001, FR-024) and SDD (3.7.1, 3.7.2) require Timeout to be reported separately so the frontend can render it in orange, distinct from red for Fail. - Add `total_timed_out` to AttestationSummary and `timed_out` to TimelineBucket - Add `is_timeout()` helper to AgentState - Change `query_counts` to return (successful, failed, timed_out) triple across both FallbackAttestationRepository and SQLite - Update `query_timeline` to distribute timed_out as a third series - Update success_rate formula to exclude both failed and timed_out from the numerator - Add unit tests for three-way split at handler, fallback repo, and SQLite repo levels Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Sergio Arroutbi <sarroutb@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Timeout (push-mode state 103) was grouped with Fail (101) as a single "failed" category. The SRS (FR-001, FR-024) and SDD (3.7.1, 3.7.2) require Timeout to be reported separately so the frontend can render it in orange, distinct from red for Fail.
total_timed_outto AttestationSummary andtimed_outto TimelineBucketis_timeout()helper to AgentStatequery_countsto return (successful, failed, timed_out) triple across both FallbackAttestationRepository and SQLitequery_timelineto distribute timed_out as a third series