Skip to content

workflows: Add test to check if RPM patches still apply#1111

Merged
ansasaki merged 1 commit intokeylime:masterfrom
ansasaki:rpm_patch_workflow
Sep 4, 2025
Merged

workflows: Add test to check if RPM patches still apply#1111
ansasaki merged 1 commit intokeylime:masterfrom
ansasaki:rpm_patch_workflow

Conversation

@ansasaki
Copy link
Copy Markdown
Contributor

@ansasaki ansasaki commented Sep 3, 2025

The tests simply try to patch the current code with the patches for both Fedora and CentOS. This is a sanity check to prevent changes changes that would make the patches incompatible to be introduced without properly updating the patches.

@ansasaki ansasaki force-pushed the rpm_patch_workflow branch 4 times, most recently from aa39f1b to 64f77e3 Compare September 3, 2025 16:31
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.03%. Comparing base (6ef9c5b) to head (da1ec5c).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
e2e-testsuite 58.03% <ø> (ø)
upstream-unit-tests 58.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@sarroutbi sarroutbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yamllint reports some issues:

  1:1       warning  missing document start "---"  (document-start)
  3:1       warning  truthy value should be one of [false, true]  (truthy)
  5:16      error    too many spaces inside brackets  (brackets)
  5:23      error    too many spaces inside brackets  (brackets)
  7:16      error    too many spaces inside brackets  (brackets)
  7:23      error    too many spaces inside brackets  (brackets)
  15:5      error    wrong indentation: expected 6 but found 4  (indentation)
  22:5      error    wrong indentation: expected 6 but found 4  (indentation)

Please, fix them if possible. It you are in a hurry, you can keep this as is and we can open an issue for them as they are easily fixable

@ansasaki
Copy link
Copy Markdown
Contributor Author

ansasaki commented Sep 4, 2025

yamllint reports some issues:

  1:1       warning  missing document start "---"  (document-start)
  3:1       warning  truthy value should be one of [false, true]  (truthy)
  5:16      error    too many spaces inside brackets  (brackets)
  5:23      error    too many spaces inside brackets  (brackets)
  7:16      error    too many spaces inside brackets  (brackets)
  7:23      error    too many spaces inside brackets  (brackets)
  15:5      error    wrong indentation: expected 6 but found 4  (indentation)
  22:5      error    wrong indentation: expected 6 but found 4  (indentation)

Please, fix them if possible. It you are in a hurry, you can keep this as is and we can open an issue for them as they are easily fixable

Fixed most of them. I think the warning about truthy value does not make much sense.

@sarroutbi
Copy link
Copy Markdown
Contributor

sarroutbi commented Sep 4, 2025

yamllint reports some issues:

  1:1       warning  missing document start "---"  (document-start)
  3:1       warning  truthy value should be one of [false, true]  (truthy)
  5:16      error    too many spaces inside brackets  (brackets)
  5:23      error    too many spaces inside brackets  (brackets)
  7:16      error    too many spaces inside brackets  (brackets)
  7:23      error    too many spaces inside brackets  (brackets)
  15:5      error    wrong indentation: expected 6 but found 4  (indentation)
  22:5      error    wrong indentation: expected 6 but found 4  (indentation)

Please, fix them if possible. It you are in a hurry, you can keep this as is and we can open an issue for them as they are easily fixable

Fixed most of them. I think the warning about truthy value does not make much sense.

Thanks. That would be enough. Normally, this means changing on to "on" but feel free to keep this as it is now as it is only a warning

Copy link
Copy Markdown
Contributor

@sarroutbi sarroutbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Anderson Toshiyuki Sasaki <ansasaki@redhat.com>
@ansasaki ansasaki merged commit fb4bcdc into keylime:master Sep 4, 2025
8 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants