Skip to content

Accept evidence handling structures null entries#1116

Merged
ansasaki merged 1 commit intokeylime:masterfrom
sarroutbi:202509041521-accept-null-entries
Sep 4, 2025
Merged

Accept evidence handling structures null entries#1116
ansasaki merged 1 commit intokeylime:masterfrom
sarroutbi:202509041521-accept-null-entries

Conversation

@sarroutbi
Copy link
Copy Markdown
Contributor

Update ImaLog and UefiLog structures to handle null entries field:

  • Change entries field from String to Option in both structures
  • Update serialization/deserialization logic to handle null values
  • Modify entry count calculation for ImaLog to handle None entries
  • Add comprehensive tests for null entries scenarios
  • Update context_info.rs to wrap entries in Some() when creating evidence

This change improves robustness when handling evidence data that may null entry fields, which can occur in certain attestation scenarios.

@sarroutbi sarroutbi force-pushed the 202509041521-accept-null-entries branch from ba8f69e to 4974d51 Compare September 4, 2025 13:27
Update ImaLog and UefiLog structures to handle null entries field:
- Change entries field from String to Option<String> in both structures
- Update serialization/deserialization logic to handle null values
- Modify entry count calculation for ImaLog to handle None entries
- Add comprehensive tests for null entries scenarios
- Update context_info.rs to wrap entries in Some() when creating evidence

This change improves robustness when handling evidence data that may
null entry fields, which can occur in certain attestation scenarios.

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Sergio Arroutbi <sarroutb@redhat.com>
@sarroutbi sarroutbi force-pushed the 202509041521-accept-null-entries branch from 4974d51 to ad357df Compare September 4, 2025 14:15
@sarroutbi
Copy link
Copy Markdown
Contributor Author

/packit retest-failed

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 4, 2025

Codecov Report

❌ Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.10%. Comparing base (fb4bcdc) to head (ad357df).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
keylime/src/structures/evidence_handling.rs 90.47% 2 Missing ⚠️
Additional details and impacted files
Flag Coverage Δ
e2e-testsuite 58.10% <91.30%> (+0.07%) ⬆️
upstream-unit-tests 58.10% <91.30%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
keylime/src/context_info.rs 53.71% <100.00%> (ø)
keylime/src/structures/evidence_handling.rs 63.50% <90.47%> (+6.25%) ⬆️

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sarroutbi
Copy link
Copy Markdown
Contributor Author

/packit retest-failed

@sarroutbi sarroutbi marked this pull request as ready for review September 4, 2025 16:34
@sarroutbi sarroutbi requested a review from ansasaki September 4, 2025 16:34
Copy link
Copy Markdown
Contributor

@ansasaki ansasaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ansasaki ansasaki merged commit 7a11dd4 into keylime:master Sep 4, 2025
16 of 17 checks passed
@sarroutbi sarroutbi deleted the 202509041521-accept-null-entries branch September 5, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants