Ensure UEFI log capabilities are set to false#1123
Merged
ansasaki merged 1 commit intokeylime:masterfrom Sep 15, 2025
Conversation
sarroutbi
force-pushed
the
202509151416-ensure-false-supports-partial-access-and-appendable-for-uefi-log
branch
from
a68d9e9 to
281c1bb
Compare
sarroutbi
changed the title
sarroutbi
force-pushed
the
202509151416-ensure-false-supports-partial-access-and-appendable-for-uefi-log
branch
2 times, most recently
from
f13c836 to
064eb84
Compare
This change corrects the supports_partial_access and appendable flags for UEFI log evidence to ensure they are always set to false. The agent was previously reporting that the UEFI event log supported partial access and was appendable. This is incorrect because the UEFI log is a complete, immutable record generated at boot time. It cannot be appended to, nor can its entries be fetched partially after the boot process is complete. This change correctly sets these two boolean flags to false, aligning the agent's reported capabilities with the actual behavior of UEFI event logs. Apart from that, added a new unit test, test_uefi_log_capabilities_flags, to verify that these flags are correctly set to false when fetching attestation data. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Sergio Arroutbi <sarroutb@redhat.com>
sarroutbi
force-pushed
the
202509151416-ensure-false-supports-partial-access-and-appendable-for-uefi-log
branch
from
064eb84 to
89b5599
Compare
Contributor
Author
|
/packit retest-failed |
1 similar comment
Contributor
Author
|
/packit retest-failed |
Codecov Report❌ Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Contributor
Author
|
/packit retest-failed |
ansasaki
approved these changes
Sep 15, 2025
sarroutbi
deleted the
202509151416-ensure-false-supports-partial-access-and-appendable-for-uefi-log
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change corrects the supports_partial_access and appendable flags
for UEFI log evidence to ensure they are always set to false.
The agent was previously reporting that the UEFI event log supported
partial access and was appendable. This is incorrect because the UEFI
log is a complete, immutable record generated at boot time. It cannot be
appended to, nor can its entries be fetched partially after the boot
process is complete.
This change correctly sets these two boolean flags to false, aligning
the agent's reported capabilities with the actual behavior of UEFI event
logs.
Apart from that, added a new unit test, test_uefi_log_capabilities_flags,
to verify that these flags are correctly set to false when fetching
attestation data.
Co-Authored-By: Claude noreply@anthropic.com