Skip to content

Fix ECC algorithm selection and reporting for keylime agent#1132

Merged
ansasaki merged 1 commit intokeylime:masterfrom
sergio-correia:ecc
Sep 25, 2025
Merged

Fix ECC algorithm selection and reporting for keylime agent#1132
ansasaki merged 1 commit intokeylime:masterfrom
sergio-correia:ecc

Conversation

@sergio-correia
Copy link
Copy Markdown
Contributor

  • Use AsymmetricAlgorithmSelection instead of AsymmetricAlgorithm to allow ecc521 to properly map to P-521 curve instead of defaulting to P-256
  • Change ECC256 algorithm display from generic "ecc" to specific "ecc256"

These changes are required for enabling ECC attestation with the NIST curves.

- Use AsymmetricAlgorithmSelection instead of AsymmetricAlgorithm
to allow ecc521 to properly map to P-521 curve instead of defaulting to P-256
- Change ECC256 algorithm display from generic "ecc" to specific "ecc256"

These changes are required for enabling ECC attestation with the NIST
curves.

Signed-off-by: Sergio Correia <scorreia@redhat.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 25, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 58.21%. Comparing base (5e32460) to head (014f809).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
keylime/src/algorithms.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
Flag Coverage Δ
e2e-testsuite 58.21% <50.00%> (+0.05%) ⬆️
upstream-unit-tests 58.21% <50.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
keylime/src/tpm.rs 67.25% <100.00%> (ø)
keylime/src/algorithms.rs 66.66% <0.00%> (ø)

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@ansasaki ansasaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ansasaki ansasaki merged commit f2979c4 into keylime:master Sep 25, 2025
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants