Remove disabled_signing_algorithms configuration#1137
Merged
ansasaki merged 1 commit intokeylime:masterfrom Sep 30, 2025
Merged
Conversation
- Changes made:
- Configuration removal: Removed disabled_signing_algorithms field
from AgentConfig and PushModelConfig structs
- Default cleanup: Removed DEFAULT_DISABLED_SIGNING_ALGORITHMS
constant and its default value ["ecschnorr"]
- Algorithm context updates: Removed disabled_signing_algorithms from
AlgorithmConfiguration, AlgorithmConfigurationString, and ContextInfo
structs
- Logic simplification: Updated get_supported_signing_schemes() to
return all TPM-supported signing algorithms without filtering
- Test updates: Removed disabled_signing_algorithms field
initialization from all test cases across multiple modules
- Configuration parsing: Removed handling of
disabled_signing_algorithms from config override functionality
- Impact:
- Signing algorithm support is now determined solely by TPM
capabilities rather than configuration filtering
- Simplifies configuration management by removing an unnecessary
configuration option
- All previously disabled algorithms (like ecschnorr) will now be
available if supported by the TPM
Signed-off-by: Sergio Arroutbi <sarroutb@redhat.com>
17e302a to
d7c6e54
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
sergio-correia
approved these changes
Sep 30, 2025
Contributor
sergio-correia
left a comment
There was a problem hiding this comment.
LGTM, thanks. Always nice to remove code :)
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes made:
Impact: