Skip to content

Remove disabled_signing_algorithms configuration#1137

Merged
ansasaki merged 1 commit intokeylime:masterfrom
sarroutbi:202509291602-remove-disable-signing-algorithms-configuration-option
Sep 30, 2025
Merged

Remove disabled_signing_algorithms configuration#1137
ansasaki merged 1 commit intokeylime:masterfrom
sarroutbi:202509291602-remove-disable-signing-algorithms-configuration-option

Conversation

@sarroutbi
Copy link
Copy Markdown
Contributor

  • Changes made:

    • Configuration removal: Removed disabled_signing_algorithms field from AgentConfig and PushModelConfig structs
    • Default cleanup: Removed DEFAULT_DISABLED_SIGNING_ALGORITHMS constant and its default value ["ecschnorr"]
    • Algorithm context updates: Removed disabled_signing_algorithms from AlgorithmConfiguration, AlgorithmConfigurationString, and ContextInfo structs
    • Logic simplification: Updated get_supported_signing_schemes() to return all TPM-supported signing algorithms without filtering
    • Test updates: Removed disabled_signing_algorithms field initialization from all test cases across multiple modules
    • Configuration parsing: Removed handling of disabled_signing_algorithms from config override functionality
  • Impact:

    • Signing algorithm support is now determined solely by TPM capabilities rather than configuration filtering
    • Simplifies configuration management by removing an unnecessary configuration option
    • All previously disabled algorithms (like ecschnorr) will now be available if supported by the TPM

- Changes made:
  - Configuration removal: Removed disabled_signing_algorithms field
    from AgentConfig and PushModelConfig structs
  - Default cleanup: Removed DEFAULT_DISABLED_SIGNING_ALGORITHMS
    constant and its default value ["ecschnorr"]
  - Algorithm context updates: Removed disabled_signing_algorithms from
    AlgorithmConfiguration, AlgorithmConfigurationString, and ContextInfo
    structs
  - Logic simplification: Updated get_supported_signing_schemes() to
    return all TPM-supported signing algorithms without filtering
  - Test updates: Removed disabled_signing_algorithms field
    initialization from all test cases across multiple modules
  - Configuration parsing: Removed handling of
    disabled_signing_algorithms from config override functionality

- Impact:
  - Signing algorithm support is now determined solely by TPM
    capabilities rather than configuration filtering
  - Simplifies configuration management by removing an unnecessary
    configuration option
  - All previously disabled algorithms (like ecschnorr) will now be
    available if supported by the TPM

Signed-off-by: Sergio Arroutbi <sarroutb@redhat.com>
@sarroutbi sarroutbi force-pushed the 202509291602-remove-disable-signing-algorithms-configuration-option branch from 17e302a to d7c6e54 Compare September 29, 2025 15:16
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.08%. Comparing base (ef2ca1a) to head (d7c6e54).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
e2e-testsuite 58.08% <100.00%> (-0.12%) ⬇️
upstream-unit-tests 58.08% <100.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ylime-push-model-agent/src/context_info_handler.rs 60.78% <ø> (-4.68%) ⬇️
keylime-push-model-agent/src/registration.rs 47.22% <ø> (ø)
keylime-push-model-agent/src/state_machine.rs 17.91% <ø> (ø)
keylime-push-model-agent/src/struct_filler.rs 25.43% <ø> (ø)
keylime/src/config/base.rs 86.62% <ø> (-1.05%) ⬇️
keylime/src/config/push_model.rs 60.00% <ø> (ø)
keylime/src/config/testing.rs 34.30% <ø> (-1.41%) ⬇️
keylime/src/context_info.rs 53.68% <100.00%> (-0.03%) ⬇️

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@sergio-correia sergio-correia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. Always nice to remove code :)

Copy link
Copy Markdown
Contributor

@ansasaki ansasaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ansasaki ansasaki merged commit 6f41aa8 into keylime:master Sep 30, 2025
21 of 22 checks passed
@sarroutbi sarroutbi deleted the 202509291602-remove-disable-signing-algorithms-configuration-option branch September 30, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants