Skip to content

fix: legacy queries need to return deprecated keyboards in some cases#42

Merged
mcdurdin merged 1 commit into
masterfrom
fix/40-deprecated-keyboards
Mar 4, 2020
Merged

fix: legacy queries need to return deprecated keyboards in some cases#42
mcdurdin merged 1 commit into
masterfrom
fix/40-deprecated-keyboards

Conversation

@mcdurdin
Copy link
Copy Markdown
Member

@mcdurdin mcdurdin commented Mar 4, 2020

Fixes #40. When doing language-specific queries, or keyboard-specific
queries, need to return deprecated keyboards as well as current ones.

Fixes #40. When doing language-specific queries, or keyboard-specific
queries, need to return deprecated keyboards as well as current ones.
@mcdurdin mcdurdin added the bug Something isn't working label Mar 4, 2020
@mcdurdin mcdurdin added this to the P10S1 milestone Mar 4, 2020
Copy link
Copy Markdown
Contributor

@darcywong00 darcywong00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcdurdin mcdurdin merged commit 0ce5313 into master Mar 4, 2020
@mcdurdin mcdurdin deleted the fix/40-deprecated-keyboards branch March 4, 2020 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecated keyboards are never returned by cloud api even if specifically requested

2 participants