Skip to content

[help.keyman.com] Lexical model schema updates#1

Merged
mcdurdin merged 6 commits into
masterfrom
lexical-model-schema-updates
Feb 14, 2019
Merged

[help.keyman.com] Lexical model schema updates#1
mcdurdin merged 6 commits into
masterfrom
lexical-model-schema-updates

Conversation

@mcdurdin
Copy link
Copy Markdown
Member

@mcdurdin mcdurdin commented Feb 8, 2019

Schema documentation for the .model_info file format, and updates to the package kmp.json metadata information.

Note that only lexical-models compiler at present is capable of generating or consuming the additional fields in kmp.json.

@mcdurdin mcdurdin changed the title [WIP] [help.keyman.com] Lexical model schema updates [help.keyman.com] Lexical model schema updates Feb 11, 2019
Comment thread developer/cloud/model_info/1.0/index.php
Comment thread developer/cloud/model_info/1.0/index.php
Copy link
Copy Markdown
Contributor

@eddieantonio eddieantonio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few things questions that I'd like addressed before approving this PR. Please see my comments.

Comment thread developer/cloud/model_info/1.0/index.php
Copy link
Copy Markdown
Contributor

@eddieantonio eddieantonio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcdurdin
Copy link
Copy Markdown
Member Author

I'm kinda ready to merge these, only I am wondering if we need to split versioning of kmp.json schema?

@mcdurdin
Copy link
Copy Markdown
Member Author

mcdurdin commented Feb 13, 2019

Blocked by #2 (no longer)

@mcdurdin mcdurdin merged commit 5bdda02 into master Feb 14, 2019
@mcdurdin mcdurdin deleted the lexical-model-schema-updates branch February 14, 2019 02:41
darcywong00 pushed a commit that referenced this pull request Feb 2, 2024
sewhite added a commit to sewhite/help.keyman.com that referenced this pull request Jun 7, 2024
The wording here is unclear. "Step 1" then "Step 2" in the headings implies you need to do keymanapp#1 then do keymanapp#2. But these are two alternate ways to share a kmp file. You can share it directly, or via a cloud service without putting it on a website, or you can put it on a website without sharing directly, or you can do both.  My wording tries to express this.
Meng-Heng added a commit that referenced this pull request Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants