refactor: clean up KeymanHosts usage and make consistent #545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Splits the server-side and client-side references to keyman sites so that docker-based PHP can reference host.docker.internal on development machines for cross-references. * Removes all remaining usage of global `$KeymanHost` variable, instead using `KeymanHost::Instance()` for consistency. * Removes some links to legacy sites such as sentry.keyman.com. * TODO: update to `BOOTSTRAP_VERSION=v0.17` in build.sh before merge. Relates-to: keymanapp/shared-sites#53
mcdurdin
added a commit
to keymanapp/api.keyman.com
that referenced
this pull request
Feb 13, 2025
* Splits the server-side and client-side references to keyman sites so that docker-based PHP can reference host.docker.internal on development machines for cross-references. * Removes some links to legacy sites such as sentry.keyman.com. * TODO: update to `BOOTSTRAP_VERSION=v0.17` in build.sh before merge. Relates-to: keymanapp/shared-sites#53 Relates-to: keymanapp/keyman.com#545
1 task
mcdurdin
added a commit
to keymanapp/keymanweb.com
that referenced
this pull request
Feb 13, 2025
* Splits the server-side and client-side references to keyman sites so that docker-based PHP can reference host.docker.internal on development machines for cross-references. * TODO: update to `BOOTSTRAP_VERSION=v0.17` in build.sh before merge. Relates-to: keymanapp/shared-sites#53 Relates-to: keymanapp/keyman.com#545 Relates-to: keymanapp/api.keyman.com#272
1 task
mcdurdin
added a commit
to keymanapp/help.keyman.com
that referenced
this pull request
Feb 13, 2025
* Splits the server-side and client-side references to keyman sites so that docker-based PHP can reference host.docker.internal on development machines for cross-references. * TODO: update to `BOOTSTRAP_VERSION=v0.17` in build.sh before merge. Relates-to: keymanapp/shared-sites#53 Relates-to: keymanapp/keyman.com#545 Relates-to: keymanapp/api.keyman.com#272 Relates-to: keymanapp/keymanweb.com#129
1 task
mcdurdin
added a commit
to keymanapp/keyman
that referenced
this pull request
Feb 13, 2025
This was an evening activity scratching itches on kmdevlink's 'Open Issue' dialog. The search box now supports three different types of strings: 1. `[[repo]#]num` -> open issue/PR #num in repo (if repo omitted, will use 'keyman'): * `13235` or `#13235` or `keyman#13235` -> opens PR #13235 * `keyman.com#545` -> opens PR keymanapp/keyman.com#545 * `api#172` -> opens PR keymanapp/api.keyman.com#172 2. `[[repo]#]searchtext` -> any non-numeric string does an issue search: * `label:ios/ font` -> opens an issue search for 'ios/' label and 'font' in keymanapp/keyman repo * `api#db` -> opens an issue search for 'db' in keymanapp/api.keyman.com repo 3. `[[repo]#]` -> opens issue list for repo (keymanapp/keyman if repo is omitted, or empty box) A second feature is construction of a HTML snippet of our usual short-form links to issues/PRs for Google Docs. Note that this dialog does not check if the target is an issue or PR, it just builds a link to the issue URL and lets GitHub redirect to PR. To use this, just type the `[[repo]#]num` format into the search field and click the Copy button.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits the server-side and client-side references to keyman sites so that docker-based PHP can reference host.docker.internal on development machines for cross-references.
Removes all remaining usage of global
$KeymanHostvariable, instead usingKeymanHost::Instance()for consistency.Removes some links to legacy sites such as sentry.keyman.com.
BOOTSTRAP_VERSION=v0.17in build.sh before merge.Relates-to: keymanapp/shared-sites#53