fix: Convert some absolute paths to relative 🌋#692
fix: Convert some absolute paths to relative 🌋#692darcywong00 merged 18 commits intoepic/i18n-url-schemefrom
Conversation
User Test ResultsTest specification and instructions User tests are not required |
_content/11/index.php
Outdated
| require_once('includes/playstore.php'); | ||
|
|
||
| require_once __DIR__ . '/../_includes/autoload.php'; | ||
| require_once __DIR__ . '/../../_includes/autoload.php'; |
There was a problem hiding this comment.
I think we may be able to reduce the work on require_once changes with #694. Sorry if that doubles up on the edits you've already done...
There was a problem hiding this comment.
Yep, I'll merge that in to this branch to continue working.
Question: How do I handle links like in the menu?
keyman.com/_includes/2020/templates/Menu.php
Lines 136 to 148 in 947c553
Some in the footer too (to /about/...)
There was a problem hiding this comment.
I think we'll need to have them aware of the current locale. e.g.
<a href="/<?=$lang?>/windows">
Or something like that. But we should try and avoid doing that except for shared content like this.
_includes/2020/templates/Foot.php
Outdated
| <a href="../_content/about/"><img id="sil-logo" src="<?php echo ImageRandomizer::randomizer(); ?>" width="50%" alt='SIL' /></a> | ||
| <p>Created by <a href="../_content/about/">SIL Global</a></p> |
There was a problem hiding this comment.
we should not be referencing _content anywhere in links. These need the $lang variable embedded
There was a problem hiding this comment.
Done with fallback to 'en'
_includes/2020/templates/Foot.php
Outdated
|
|
||
| <div id='footer-get-involved'> | ||
| <a href="/about/get-involved">Get involved</a> | ||
| <a href="../_content/about/get-involved">Get involved</a> |
Co-authored-by: Marc Durdin <marc@durdin.net>
Co-authored-by: Marc Durdin <marc@durdin.net>
7226886 to
630bf8a
Compare
630bf8a to
a8ea9d9
Compare
Co-authored-by: Marc Durdin <marc@durdin.net>
Follows #691 for #687
Fixes some of the relative paths for upcoming i18n
* Fix relative path toautoload.phpLeaving these absolute paths intact for now:
link-checker will be broken for quite a while as there's a lot of refactoring todo
Test-bot: skip